Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: refactor to use validateObject() validator #41845

Merged
merged 1 commit into from
Feb 6, 2022
Merged

lib: refactor to use validateObject() validator #41845

merged 1 commit into from
Feb 6, 2022

Conversation

VoltrexKeyva
Copy link
Member

Use the validateObject() validator in source maps where appropriate.

@VoltrexKeyva
lib: refactor to use validateObject() validator
adf6d80 
Use the `validateObject()` validator in source maps where appropriate.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 4, 2022
@VoltrexKeyva VoltrexKeyva added the source maps Issues and PRs related to source map support. label Feb 4, 2022
@VoltrexKeyva VoltrexKeyva added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 4, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 4, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 4, 2022 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/42350/ 💛

@VoltrexKeyva VoltrexKeyva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Feb 4, 2022
@github-actions github-actions bot mentioned this pull request Feb 5, 2022
Open
35 tasks
@github-actions github-actions bot mentioned this pull request Feb 6, 2022
Open
27 tasks
@Mesteery Mesteery added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 6, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 6, 2022
@nodejs-github-bot nodejs-github-bot merged commit 4712472 into nodejs:master Feb 6, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 4712472

@VoltrexKeyva VoltrexKeyva deleted the srcmps-use-validate-object branch February 6, 2022 21:09
This was referenced Feb 7, 2022
Open
Open
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@VoltrexKeyva @ruyadorno
lib: refactor to use validateObject() validator
59a15e8 
Use the `validateObject()` validator in source maps where appropriate.

PR-URL: #41845
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@VoltrexKeyva @danielleadams
lib: refactor to use validateObject() validator
18037c6 
Use the `validateObject()` validator in source maps where appropriate.

PR-URL: #41845
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@VoltrexKeyva @danielleadams
lib: refactor to use validateObject() validator
eff1c4b 
Use the `validateObject()` validator in source maps where appropriate.

PR-URL: #41845
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@VoltrexKeyva @danielleadams
lib: refactor to use validateObject() validator
3f14458 
Use the `validateObject()` validator in source maps where appropriate.

PR-URL: nodejs#41845
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this pull request Mar 4, 2022
@VoltrexKeyva @danielleadams
lib: refactor to use validateObject() validator
2647931 
Use the `validateObject()` validator in source maps where appropriate.

PR-URL: nodejs#41845
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 8, 2022
@VoltrexKeyva @danielleadams
lib: refactor to use validateObject() validator
8a2e782 
Use the `validateObject()` validator in source maps where appropriate.

PR-URL: #41845
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@VoltrexKeyva @danielleadams
lib: refactor to use validateObject() validator
c90bb7c 
Use the `validateObject()` validator in source maps where appropriate.

PR-URL: #41845
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery approved these changes

@aduh95 aduh95 aduh95 approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. source maps Issues and PRs related to source map support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@VoltrexKeyva @nodejs-github-bot @jasnell @cjihrig @Lxxyx @aduh95 @Mesteery