Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: allow returning null from pipeline tail #42078

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

ronag
Copy link
Member

@ronag ronag commented Feb 22, 2022

No description provided.

@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Feb 22, 2022
@ronag ronag requested review from mcollina and benjamingr February 22, 2022 14:32
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/streams

@ronag
Copy link
Member Author

ronag commented Feb 22, 2022

@nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 22, 2022
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Feb 22, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2022
@nodejs-github-bot

This comment was marked as outdated.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 23, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/42078
✔  Done loading data for nodejs/node/pull/42078
----------------------------------- PR info ------------------------------------
Title      stream: allow returning null from pipeline tail (#42078)
Author     Robert Nagy  (@ronag)
Branch     ronag:pipeline-null -> nodejs:master
Labels     stream
Commits    1
 - stream: allow returning null from pipeline tail
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/42078
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42078
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 22 Feb 2022 14:32:00 GMT
   ✔  Approvals: 3
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/42078#pullrequestreview-889935566
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/42078#pullrequestreview-889955872
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/42078#pullrequestreview-890894764
   ✖  This PR needs to wait 24 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-02-23T13:23:52Z: https://ci.nodejs.org/job/node-test-pull-request/42739/
- Querying data for job/node-test-pull-request/42739/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1887812437

@Mesteery Mesteery added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 25, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2022
@nodejs-github-bot nodejs-github-bot merged commit 1b47866 into nodejs:master Feb 25, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 1b47866

sxa pushed a commit to sxa/node that referenced this pull request Mar 7, 2022
PR-URL: nodejs#42078
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@sxa sxa mentioned this pull request Mar 8, 2022
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
PR-URL: nodejs#42078
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@juanarbol juanarbol assigned juanarbol and unassigned juanarbol May 29, 2022
@juanarbol
Copy link
Member

This won't land clean in v16.x until #40881 is backported to v16.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants