http: make TCP noDelay enabled by default #42163

ShogunPanda · 2022-03-01T09:43:08Z

This PR is the continuation of the work in #41310 and it is aimed to close #34185.

The PR changes noDelay to be true by default in http.Server and http.Agent (which is also used by http.request). This implies that all HTTP connections (both inbound and outbound) disable Nagle's algorithm by default.

nodejs-github-bot · 2022-03-01T09:43:12Z

Review requested:

@nodejs/http
@nodejs/net

aduh95 · 2022-03-01T10:12:44Z

Adding semver-major PRs that contain breaking changes and should be released in the next major version. as I think changing the default is a breaking change. Can you add entries in changes YAML lists in the docs please?

ShogunPanda · 2022-03-01T10:40:02Z

Yes, it's definitely a semver major. I'll double think about the impact of this.
I've updated the docs as requested.

doc/api/http.md

bnoordhuis · 2022-03-01T10:56:11Z

Disabling Nagle is probably uncontroversial (pretty standard practice nowadays) but turning on keep-alive...

Keep-alive makes truly dead connections take way longer to time out. That's often not what you want with HTTP.

ShogunPanda · 2022-03-01T14:58:10Z

@bnoordhuis I agree. Keep had too many side effects. I might try that again after #41578 is handled (I might send a PR for that soon). For this PR I reverted to only disable Nagle's algorithm.

Trott · 2022-03-01T16:56:56Z

@nodejs/tsc This is semver-major and needs some TSC approvals if it is to land. I believe @ShogunPanda wants to get it in for 18.0.0 so sometime in March would be great, if there's consensus.

richardlau · 2022-03-01T17:19:37Z

doc/api/http.md

+    description: The `noDelay`, `keepAlive` and `keepAliveInitialDelay`
+                 options are supported now.


I think this PR only changes noDelay now? (Same with the change to net.md).

Technically yes. But in the PR where I originally added it I forgot to update the docs' changelog. 😞

Shall I revert the modification or is it good?

Ah I didn't spot the PR-URL was for an earlier PR. Keep those, but add a new entry for this PR noting the default has been changed for noDelay.

Done! Does it look fine now?

ShogunPanda · 2022-03-01T18:58:27Z

@nodejs/tsc This is semver-major and needs some TSC approvals if it is to land. I believe @ShogunPanda wants to get it in for 18.0.0 so sometime in March would be great, if there's consensus.

Yes, I do confirm I'd like it to land in 18.0.0.

mcollina

lgtm

nodejs-github-bot · 2022-03-02T12:05:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42834/

nodejs-github-bot · 2022-03-04T14:21:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42867/

mcollina · 2022-03-04T15:23:36Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2862/

mcollina · 2022-03-07T15:03:39Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2866/

(Fastify and undici failures were unrelated).

mcollina · 2022-03-09T08:54:30Z

CITGM (fresh): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2873/

updated Fastify again.

mcollina · 2022-03-09T10:33:28Z

CITGM (master): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2874/

mcollina · 2022-03-09T14:25:33Z

CITGM is ok, this can land

nodejs-github-bot · 2022-03-09T14:37:52Z

Landed in eacd456

aduh95 · 2022-03-09T14:40:06Z

doc/api/net.md

+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/41310
+    description: The `noDelay`, `keepAlive` and `keepAliveInitialDelay`
+                 options are supported now.


This should have gone to its own PR, since this PR is semver-major it will land on v18.0.0, while #41310 will land on v17.7.0.

EDIT: PR to fix that is #42268.

mcollina · 2022-03-09T15:02:11Z

Ah damn, my bad.

Notable Changes: Deprecations and Removals: - (SEMVER-MAJOR) fs: runtime deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) (#42607) - (SEMVER-MAJOR) dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion (Antoine du Hamel) (#41431) - (SEMVER-MAJOR) process: runtime deprecate multipleResolves (Benjamin Gruenbaum) (#41896) - (SEMVER-MAJOR) stream: remove thenable support (Robert Nagy) (#40773) - (SEMVER-MAJOR) tls: move tls.parseCertString to end-of-life (Tobias Nießen) (#41479) fetch (experimental): An experimental fetch API is available on the global scope by default. The implementation is based upon https://undici.nodejs.org/#/, an HTTP/1.1 client written for Node.js by contributors to the project. Through this addition, the following globals are made available: `fetch` , `FormData`, `Headers`, `Request`, `Response`. Disable this API with the `--no-experimental-fetch` command-line flag. Contributed by Michaël Zasso in #41811. HTTP Timeouts: `server.headersTimeout`, which limits the amount of time the parser will wait to receive the complete HTTP headers, is now set to `60000` (60 seconds) by default. `server.requestTimeout`, which sets the timeout value in milliseconds for receiving the entire request from the client, is now set to `300000` (5 minutes) by default. If these timeouts expire, the server responds with status 408 without forwarding the request to the request listener and then closes the connection. Both timeouts must be set to a non-zero value to protect against potential Denial-of-Service attacks in case the server is deployed without a reverse proxy in front. Contributed by Paolo Insogna in #41263. Test Runner module (experimental): The `node:test` module facilitates the creation of JavaScript tests that report results in TAP format. This module is only available under the `node:` scheme. Contributed by Colin Ihrig in #42325. Toolchain and Compiler Upgrades: - Prebuilt binaries for Linux are now built on Red Hat Enterprise Linux (RHEL) 8 and are compatible with Linux distributions based on glibc 2.28 or later, for example, Debian 10, RHEL 8, Ubuntu 20.04. - Prebuilt binaries for macOS now require macOS 10.15 or later. - For AIX the minimum supported architecture has been raised from Power 7 to Power 8. Prebuilt binaries for 32-bit Windows will initially not be available due to issues building the V8 dependency in Node.js. We hope to restore 32-bit Windows binaries for Node.js 18 with a future V8 update. Node.js does not support running on operating systems that are no longer supported by their vendor. For operating systems where their vendor has planned to end support earlier than April 2025, such as Windows 8.1 (January 2023) and Windows Server 2012 R2 (October 2023), support for Node.js 18 will end at the earlier date. Full details about the supported toolchains and compilers are documented in the Node.js `BUILDING.md` file. Contributed by Richard Lau in #42292, #42604 and #42659 , and Michaël Zasso in #42105 and #42666. V8 10.1: The V8 engine is updated to version 10.1, which is part of Chromium 101. Compared to the version included in Node.js 17.9.0, the following new features are included: - The `findLast` and `findLastIndex` array methods. - Improvements to the `Intl.Locale` API. - The `Intl.supportedValuesOf` function. - Improved performance of class fields and private class methods (the initialization of them is now as fast as ordinary property stores). The data format returned by the serialization API (`v8.serialize(value)`) has changed, and cannot be deserialized by earlier versions of Node.js. On the other hand, it is still possible to deserialize the previous format, as the API is backwards-compatible. Contributed by Michaël Zasso in #42657. Web Streams API (experimental): Node.js now exposes the experimental implementation of the Web Streams API on the global scope. This means the following APIs are now globally available: - `ReadableStream`, `ReadableStreamDefaultReader`, `ReadableStreamBYOBReader`, `ReadableStreamBYOBRequest`, `ReadableByteStreamController`, `ReadableStreamDefaultController`, `TransformStream`, `TransformStreamDefaultController`, `WritableStream`, `WritableStreamDefaultWriter`, `WritableStreamDefaultController`, `ByteLengthQueuingStrategy`, `CountQueuingStrategy`, `TextEncoderStream`, `TextDecoderStream`, `CompressionStream`, `DecompressionStream`. Contributed James Snell in #39062, and Antoine du Hamel in #42225. Other Notable Changes: - (SEMVER-MAJOR) buffer: expose Blob as a global (James M Snell) (#41270) - (SEMVER-MAJOR) child\_process: improve argument validation (Rich Trott) (#41305) - doc: add RafaelGSS to collaborators (RafaelGSS) (#42718) - (SEMVER-MAJOR) http: make TCP noDelay enabled by default (Paolo Insogna) (#42163) - (SEMVER-MAJOR) net: make `server.address()` return an integer for `family` (Antoine du Hamel) (#41431) - (SEMVER-MAJOR) worker: expose BroadcastChannel as a global (James M Snell) (#41271) - (SEMVER-MAJOR) worker: graduate BroadcastChannel to supported (James M Snell) (#41271) Semver-Major Commits: - (SEMVER-MAJOR) assert,util: compare RegExp.lastIndex while using deep equal checks (Ruben Bridgewater) (#41020) - (SEMVER-MAJOR) buffer: refactor `byteLength` to remove outdated optimizations (Rongjian Zhang) (#38545) - (SEMVER-MAJOR) buffer: expose Blob as a global (James M Snell) (#41270) - (SEMVER-MAJOR) buffer: graduate Blob from experimental (James M Snell) (#41270) - (SEMVER-MAJOR) build: make x86 Windows support temporarily experimental (Michaël Zasso) (#42666) - (SEMVER-MAJOR) build: bump macOS deployment target to 10.15 (Richard Lau) (#42292) - (SEMVER-MAJOR) build: downgrade Windows 8.1 and server 2012 R2 to experimental (Michaël Zasso) (#42105) - (SEMVER-MAJOR) child\_process: improve argument validation (Rich Trott) (#41305) - (SEMVER-MAJOR) cluster: make `kill` to be just `process.kill` (Bar Admoni) (#34312) - (SEMVER-MAJOR) crypto: cleanup validation (Mohammed Keyvanzadeh) (#39841) - (SEMVER-MAJOR) crypto: prettify othername in PrintGeneralName (Tobias Nießen) (#42123) - (SEMVER-MAJOR) crypto: fix X509Certificate toLegacyObject (Tobias Nießen) (#42124) - (SEMVER-MAJOR) crypto: use RFC2253 format in PrintGeneralName (Tobias Nießen) (#42002) - (SEMVER-MAJOR) crypto: change default check(Host|Email) behavior (Tobias Nießen) (#41600) - (SEMVER-MAJOR) deps: V8: cherry-pick semver-major commits from 10.2 (Michaël Zasso) (#42657) - (SEMVER-MAJOR) deps: update V8 to 10.1.124.6 (Michaël Zasso) (#42657) - (SEMVER-MAJOR) deps: update V8 to 9.8.177.9 (Michaël Zasso) (#41610) - (SEMVER-MAJOR) deps: update V8 to 9.7.106.18 (Michaël Zasso) (#40907) - (SEMVER-MAJOR) dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion (Antoine du Hamel) (#41431) - (SEMVER-MAJOR) doc: update minimum glibc requirements for Linux (Richard Lau) (#42659) - (SEMVER-MAJOR) doc: update AIX minimum supported arch (Richard Lau) (#42604) - (SEMVER-MAJOR) fs: runtime deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) (#42607) - (SEMVER-MAJOR) http: refactor headersTimeout and requestTimeout logic (Paolo Insogna) (#41263) - (SEMVER-MAJOR) http: make TCP noDelay enabled by default (Paolo Insogna) (#42163) - (SEMVER-MAJOR) lib: enable fetch by default (Michaël Zasso) (#41811) - (SEMVER-MAJOR) lib: replace validator and error (Mohammed Keyvanzadeh) (#41678) - (SEMVER-MAJOR) module,repl: support 'node:'-only core modules (Colin Ihrig) (#42325) - (SEMVER-MAJOR) net: make `server.address()` return an integer for `family` (Antoine du Hamel) (#41431) - (SEMVER-MAJOR) process: disallow some uses of Object.defineProperty() on process.env (Himself65) (#28006) - (SEMVER-MAJOR) process: runtime deprecate multipleResolves (Benjamin Gruenbaum) (#41896) - (SEMVER-MAJOR) readline: fix question still called after closed (Xuguang Mei) (#42464) - (SEMVER-MAJOR) stream: remove thenable support (Robert Nagy) (#40773) - (SEMVER-MAJOR) stream: expose web streams globals, remove runtime experimental warning (Antoine du Hamel) (#42225) - (SEMVER-MAJOR) stream: need to cleanup event listeners if last stream is readable (Xuguang Mei) (#41954) - (SEMVER-MAJOR) stream: revert revert `map` spec compliance (Benjamin Gruenbaum) (#41933) - (SEMVER-MAJOR) stream: throw invalid arg type from End Of Stream (Jithil P Ponnan) (#41766) - (SEMVER-MAJOR) stream: don't emit finish after destroy (Robert Nagy) (#40852) - (SEMVER-MAJOR) stream: add errored and closed props (Robert Nagy) (#40696) - (SEMVER-MAJOR) test: add initial test module (Colin Ihrig) (#42325) - (SEMVER-MAJOR) timers: refactor internal classes to ES2015 syntax (Rabbit) (#37408) - (SEMVER-MAJOR) tls: represent registeredID numerically always (Tobias Nießen) (#41561) - (SEMVER-MAJOR) tls: move tls.parseCertString to end-of-life (Tobias Nießen) (#41479) - (SEMVER-MAJOR) url: throw on NULL in IPv6 hostname (Rich Trott) (#42313) - (SEMVER-MAJOR) v8: make v8.writeHeapSnapshot() error codes consistent (Darshan Sen) (#42577) - (SEMVER-MAJOR) v8: make writeHeapSnapshot throw if fopen fails (Antonio Román) (#41373) - (SEMVER-MAJOR) worker: expose BroadcastChannel as a global (James M Snell) (#41271) - (SEMVER-MAJOR) worker: graduate BroadcastChannel to supported (James M Snell) (#41271) PR-URL: #42262

PR-URL: nodejs#42163 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

Notable Changes: Deprecations and Removals: - (SEMVER-MAJOR) fs: runtime deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) (nodejs#42607) - (SEMVER-MAJOR) dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion (Antoine du Hamel) (nodejs#41431) - (SEMVER-MAJOR) process: runtime deprecate multipleResolves (Benjamin Gruenbaum) (nodejs#41896) - (SEMVER-MAJOR) stream: remove thenable support (Robert Nagy) (nodejs#40773) - (SEMVER-MAJOR) tls: move tls.parseCertString to end-of-life (Tobias Nießen) (nodejs#41479) fetch (experimental): An experimental fetch API is available on the global scope by default. The implementation is based upon https://undici.nodejs.org/#/, an HTTP/1.1 client written for Node.js by contributors to the project. Through this addition, the following globals are made available: `fetch` , `FormData`, `Headers`, `Request`, `Response`. Disable this API with the `--no-experimental-fetch` command-line flag. Contributed by Michaël Zasso in nodejs#41811. HTTP Timeouts: `server.headersTimeout`, which limits the amount of time the parser will wait to receive the complete HTTP headers, is now set to `60000` (60 seconds) by default. `server.requestTimeout`, which sets the timeout value in milliseconds for receiving the entire request from the client, is now set to `300000` (5 minutes) by default. If these timeouts expire, the server responds with status 408 without forwarding the request to the request listener and then closes the connection. Both timeouts must be set to a non-zero value to protect against potential Denial-of-Service attacks in case the server is deployed without a reverse proxy in front. Contributed by Paolo Insogna in nodejs#41263. Test Runner module (experimental): The `node:test` module facilitates the creation of JavaScript tests that report results in TAP format. This module is only available under the `node:` scheme. Contributed by Colin Ihrig in nodejs#42325. Toolchain and Compiler Upgrades: - Prebuilt binaries for Linux are now built on Red Hat Enterprise Linux (RHEL) 8 and are compatible with Linux distributions based on glibc 2.28 or later, for example, Debian 10, RHEL 8, Ubuntu 20.04. - Prebuilt binaries for macOS now require macOS 10.15 or later. - For AIX the minimum supported architecture has been raised from Power 7 to Power 8. Prebuilt binaries for 32-bit Windows will initially not be available due to issues building the V8 dependency in Node.js. We hope to restore 32-bit Windows binaries for Node.js 18 with a future V8 update. Node.js does not support running on operating systems that are no longer supported by their vendor. For operating systems where their vendor has planned to end support earlier than April 2025, such as Windows 8.1 (January 2023) and Windows Server 2012 R2 (October 2023), support for Node.js 18 will end at the earlier date. Full details about the supported toolchains and compilers are documented in the Node.js `BUILDING.md` file. Contributed by Richard Lau in nodejs#42292, nodejs#42604 and nodejs#42659 , and Michaël Zasso in nodejs#42105 and nodejs#42666. V8 10.1: The V8 engine is updated to version 10.1, which is part of Chromium 101. Compared to the version included in Node.js 17.9.0, the following new features are included: - The `findLast` and `findLastIndex` array methods. - Improvements to the `Intl.Locale` API. - The `Intl.supportedValuesOf` function. - Improved performance of class fields and private class methods (the initialization of them is now as fast as ordinary property stores). The data format returned by the serialization API (`v8.serialize(value)`) has changed, and cannot be deserialized by earlier versions of Node.js. On the other hand, it is still possible to deserialize the previous format, as the API is backwards-compatible. Contributed by Michaël Zasso in nodejs#42657. Web Streams API (experimental): Node.js now exposes the experimental implementation of the Web Streams API on the global scope. This means the following APIs are now globally available: - `ReadableStream`, `ReadableStreamDefaultReader`, `ReadableStreamBYOBReader`, `ReadableStreamBYOBRequest`, `ReadableByteStreamController`, `ReadableStreamDefaultController`, `TransformStream`, `TransformStreamDefaultController`, `WritableStream`, `WritableStreamDefaultWriter`, `WritableStreamDefaultController`, `ByteLengthQueuingStrategy`, `CountQueuingStrategy`, `TextEncoderStream`, `TextDecoderStream`, `CompressionStream`, `DecompressionStream`. Contributed James Snell in nodejs#39062, and Antoine du Hamel in nodejs#42225. Other Notable Changes: - (SEMVER-MAJOR) buffer: expose Blob as a global (James M Snell) (nodejs#41270) - (SEMVER-MAJOR) child\_process: improve argument validation (Rich Trott) (nodejs#41305) - doc: add RafaelGSS to collaborators (RafaelGSS) (nodejs#42718) - (SEMVER-MAJOR) http: make TCP noDelay enabled by default (Paolo Insogna) (nodejs#42163) - (SEMVER-MAJOR) net: make `server.address()` return an integer for `family` (Antoine du Hamel) (nodejs#41431) - (SEMVER-MAJOR) worker: expose BroadcastChannel as a global (James M Snell) (nodejs#41271) - (SEMVER-MAJOR) worker: graduate BroadcastChannel to supported (James M Snell) (nodejs#41271) Semver-Major Commits: - (SEMVER-MAJOR) assert,util: compare RegExp.lastIndex while using deep equal checks (Ruben Bridgewater) (nodejs#41020) - (SEMVER-MAJOR) buffer: refactor `byteLength` to remove outdated optimizations (Rongjian Zhang) (nodejs#38545) - (SEMVER-MAJOR) buffer: expose Blob as a global (James M Snell) (nodejs#41270) - (SEMVER-MAJOR) buffer: graduate Blob from experimental (James M Snell) (nodejs#41270) - (SEMVER-MAJOR) build: make x86 Windows support temporarily experimental (Michaël Zasso) (nodejs#42666) - (SEMVER-MAJOR) build: bump macOS deployment target to 10.15 (Richard Lau) (nodejs#42292) - (SEMVER-MAJOR) build: downgrade Windows 8.1 and server 2012 R2 to experimental (Michaël Zasso) (nodejs#42105) - (SEMVER-MAJOR) child\_process: improve argument validation (Rich Trott) (nodejs#41305) - (SEMVER-MAJOR) cluster: make `kill` to be just `process.kill` (Bar Admoni) (nodejs#34312) - (SEMVER-MAJOR) crypto: cleanup validation (Mohammed Keyvanzadeh) (nodejs#39841) - (SEMVER-MAJOR) crypto: prettify othername in PrintGeneralName (Tobias Nießen) (nodejs#42123) - (SEMVER-MAJOR) crypto: fix X509Certificate toLegacyObject (Tobias Nießen) (nodejs#42124) - (SEMVER-MAJOR) crypto: use RFC2253 format in PrintGeneralName (Tobias Nießen) (nodejs#42002) - (SEMVER-MAJOR) crypto: change default check(Host|Email) behavior (Tobias Nießen) (nodejs#41600) - (SEMVER-MAJOR) deps: V8: cherry-pick semver-major commits from 10.2 (Michaël Zasso) (nodejs#42657) - (SEMVER-MAJOR) deps: update V8 to 10.1.124.6 (Michaël Zasso) (nodejs#42657) - (SEMVER-MAJOR) deps: update V8 to 9.8.177.9 (Michaël Zasso) (nodejs#41610) - (SEMVER-MAJOR) deps: update V8 to 9.7.106.18 (Michaël Zasso) (nodejs#40907) - (SEMVER-MAJOR) dns: remove `dns.lookup` and `dnsPromises.lookup` options type coercion (Antoine du Hamel) (nodejs#41431) - (SEMVER-MAJOR) doc: update minimum glibc requirements for Linux (Richard Lau) (nodejs#42659) - (SEMVER-MAJOR) doc: update AIX minimum supported arch (Richard Lau) (nodejs#42604) - (SEMVER-MAJOR) fs: runtime deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) (nodejs#42607) - (SEMVER-MAJOR) http: refactor headersTimeout and requestTimeout logic (Paolo Insogna) (nodejs#41263) - (SEMVER-MAJOR) http: make TCP noDelay enabled by default (Paolo Insogna) (nodejs#42163) - (SEMVER-MAJOR) lib: enable fetch by default (Michaël Zasso) (nodejs#41811) - (SEMVER-MAJOR) lib: replace validator and error (Mohammed Keyvanzadeh) (nodejs#41678) - (SEMVER-MAJOR) module,repl: support 'node:'-only core modules (Colin Ihrig) (nodejs#42325) - (SEMVER-MAJOR) net: make `server.address()` return an integer for `family` (Antoine du Hamel) (nodejs#41431) - (SEMVER-MAJOR) process: disallow some uses of Object.defineProperty() on process.env (Himself65) (nodejs#28006) - (SEMVER-MAJOR) process: runtime deprecate multipleResolves (Benjamin Gruenbaum) (nodejs#41896) - (SEMVER-MAJOR) readline: fix question still called after closed (Xuguang Mei) (nodejs#42464) - (SEMVER-MAJOR) stream: remove thenable support (Robert Nagy) (nodejs#40773) - (SEMVER-MAJOR) stream: expose web streams globals, remove runtime experimental warning (Antoine du Hamel) (nodejs#42225) - (SEMVER-MAJOR) stream: need to cleanup event listeners if last stream is readable (Xuguang Mei) (nodejs#41954) - (SEMVER-MAJOR) stream: revert revert `map` spec compliance (Benjamin Gruenbaum) (nodejs#41933) - (SEMVER-MAJOR) stream: throw invalid arg type from End Of Stream (Jithil P Ponnan) (nodejs#41766) - (SEMVER-MAJOR) stream: don't emit finish after destroy (Robert Nagy) (nodejs#40852) - (SEMVER-MAJOR) stream: add errored and closed props (Robert Nagy) (nodejs#40696) - (SEMVER-MAJOR) test: add initial test module (Colin Ihrig) (nodejs#42325) - (SEMVER-MAJOR) timers: refactor internal classes to ES2015 syntax (Rabbit) (nodejs#37408) - (SEMVER-MAJOR) tls: represent registeredID numerically always (Tobias Nießen) (nodejs#41561) - (SEMVER-MAJOR) tls: move tls.parseCertString to end-of-life (Tobias Nießen) (nodejs#41479) - (SEMVER-MAJOR) url: throw on NULL in IPv6 hostname (Rich Trott) (nodejs#42313) - (SEMVER-MAJOR) v8: make v8.writeHeapSnapshot() error codes consistent (Darshan Sen) (nodejs#42577) - (SEMVER-MAJOR) v8: make writeHeapSnapshot throw if fopen fails (Antonio Román) (nodejs#41373) - (SEMVER-MAJOR) worker: expose BroadcastChannel as a global (James M Snell) (nodejs#41271) - (SEMVER-MAJOR) worker: graduate BroadcastChannel to supported (James M Snell) (nodejs#41271) PR-URL: nodejs#42262

nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Mar 1, 2022

ShogunPanda changed the title ~~feat: Make http.keepAlive and http.noDelay enabled by default.~~ net: make http.keepAlive and http.noDelay enabled by default Mar 1, 2022

ShogunPanda force-pushed the http-enable-no-delay-keepalive branch from 84c4cdb to e2dba6d Compare March 1, 2022 09:45

ShogunPanda changed the title ~~net: make http.keepAlive and http.noDelay enabled by default~~ net: make TCP keep-alive and TCP noDelay enabled by default Mar 1, 2022

ShogunPanda mentioned this pull request Mar 1, 2022

Preparation for v18.0.0 #42139

Closed

24 tasks

aduh95 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 1, 2022

ShogunPanda force-pushed the http-enable-no-delay-keepalive branch from 93f3307 to 17cd6c6 Compare March 1, 2022 10:36

ShogunPanda changed the title ~~net: make TCP keep-alive and TCP noDelay enabled by default~~ http: make TCP keep-alive and TCP noDelay enabled by default Mar 1, 2022

ShogunPanda force-pushed the http-enable-no-delay-keepalive branch from 17cd6c6 to 6151760 Compare March 1, 2022 10:39

aduh95 reviewed Mar 1, 2022

View reviewed changes

doc/api/http.md Outdated Show resolved Hide resolved

aduh95 added the needs-citgm PRs that need a CITGM CI run. label Mar 1, 2022

ShogunPanda force-pushed the http-enable-no-delay-keepalive branch 2 times, most recently from d7016f5 to a235004 Compare March 1, 2022 14:56

ShogunPanda changed the title ~~http: make TCP keep-alive and TCP noDelay enabled by default~~ http: make TCP noDelay enabled by default Mar 1, 2022

richardlau added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 1, 2022

richardlau reviewed Mar 1, 2022

View reviewed changes

mcollina approved these changes Mar 2, 2022

View reviewed changes

ronag approved these changes Mar 2, 2022

View reviewed changes

ShogunPanda added 2 commits March 2, 2022 14:01

http: make TCP noDelay enabled by default

e2b81e1

doc: update option changelog

d368d23

ShogunPanda force-pushed the http-enable-no-delay-keepalive branch from a235004 to d368d23 Compare March 2, 2022 13:02

mcollina added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. labels Mar 4, 2022

This was referenced Mar 8, 2022

CI Reliability 2022-03-08 nodejs/reliability#214

Open

CI Reliability 2022-03-09 nodejs/reliability#215

Open

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 9, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 9, 2022

nodejs-github-bot merged commit eacd456 into nodejs:master Mar 9, 2022

ShogunPanda deleted the http-enable-no-delay-keepalive branch March 9, 2022 14:38

aduh95 reviewed Mar 9, 2022

View reviewed changes

aduh95 mentioned this pull request Mar 9, 2022

doc: fix version history for net.Socket and net.Server #42268

Merged

This was referenced Mar 10, 2022

CI Reliability 2022-03-10 nodejs/reliability#216

Open

CI Reliability 2022-03-11 nodejs/reliability#217

Open

voxpelli mentioned this pull request Mar 22, 2022

net: activate setNoDelay by default #40778

Closed

3 tasks

BethGriggs mentioned this pull request Mar 28, 2022

2022-04-19, Version 18.0.0 (Current) #42262

Merged

tatethurston mentioned this pull request Aug 30, 2023

Give Callers the Ability to set TCP_NODELAY tatethurston/TwirpScript#223

Closed

jokester mentioned this pull request Mar 31, 2024

Add TCP_NODELAY jokester/publicaddr#17

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

http: make TCP noDelay enabled by default #42163

http: make TCP noDelay enabled by default #42163

ShogunPanda commented Mar 1, 2022 •

edited

Loading

nodejs-github-bot commented Mar 1, 2022

aduh95 commented Mar 1, 2022

ShogunPanda commented Mar 1, 2022

bnoordhuis commented Mar 1, 2022

ShogunPanda commented Mar 1, 2022

Trott commented Mar 1, 2022

richardlau Mar 1, 2022

ShogunPanda Mar 1, 2022

richardlau Mar 1, 2022 •

edited

Loading

ShogunPanda Mar 2, 2022

ShogunPanda commented Mar 1, 2022

mcollina left a comment

nodejs-github-bot commented Mar 2, 2022

nodejs-github-bot commented Mar 4, 2022

mcollina commented Mar 4, 2022

mcollina commented Mar 7, 2022

mcollina commented Mar 9, 2022

mcollina commented Mar 9, 2022

mcollina commented Mar 9, 2022

nodejs-github-bot commented Mar 9, 2022

aduh95 Mar 9, 2022 •

edited

Loading

mcollina commented Mar 9, 2022

		description: The `noDelay`, `keepAlive` and `keepAliveInitialDelay`
		options are supported now.

http: make TCP noDelay enabled by default #42163

http: make TCP noDelay enabled by default #42163

Conversation

ShogunPanda commented Mar 1, 2022 • edited Loading

nodejs-github-bot commented Mar 1, 2022

aduh95 commented Mar 1, 2022

ShogunPanda commented Mar 1, 2022

bnoordhuis commented Mar 1, 2022

ShogunPanda commented Mar 1, 2022

Trott commented Mar 1, 2022

richardlau Mar 1, 2022

Choose a reason for hiding this comment

ShogunPanda Mar 1, 2022

Choose a reason for hiding this comment

richardlau Mar 1, 2022 • edited Loading

Choose a reason for hiding this comment

ShogunPanda Mar 2, 2022

Choose a reason for hiding this comment

ShogunPanda commented Mar 1, 2022

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Mar 2, 2022

nodejs-github-bot commented Mar 4, 2022

mcollina commented Mar 4, 2022

mcollina commented Mar 7, 2022

mcollina commented Mar 9, 2022

mcollina commented Mar 9, 2022

mcollina commented Mar 9, 2022

nodejs-github-bot commented Mar 9, 2022

aduh95 Mar 9, 2022 • edited Loading

Choose a reason for hiding this comment

mcollina commented Mar 9, 2022

ShogunPanda commented Mar 1, 2022 •

edited

Loading

richardlau Mar 1, 2022 •

edited

Loading

aduh95 Mar 9, 2022 •

edited

Loading