Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add riscv64 info into platform list #42251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luyahan
Copy link
Contributor

@luyahan luyahan commented Mar 8, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Mar 8, 2022
@Trott
Copy link
Member

Trott commented Mar 8, 2022

@nodejs/build

@Trott
Copy link
Member

Trott commented Mar 8, 2022

It's not clear to me that there's an ordering beyond some clustering in the list, but if there is ordering, it would be great if someone can confirm that this entry is in the right place.

@rvagg
Copy link
Member

rvagg commented Mar 8, 2022

I'm not sure we can add this, we don't have it in our CI in any form yet and I think @sxa is the only member of the team that's even attempted to toy with this. Having it in this list suggests some level of support but I don't think we're in a position to offer anything yet. Perhaps if we can pull together a functional @nodejs/platform-risc this might make sense but I'm not sure if we want to be signalling anything relating to "support" re risc yet.

So I'm a soft -1 on this.

Anyone else want to weigh in?

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having it in this list suggests some level of support

I suppose the question would be whether the other platforms we have as experimental (armv6, xLinux 32-bit) are in the same state now. I'd suggest at least holding off merging until we get get an unofficial build in place (I've got one running elsewhere on a regular basis - I just need to get it integrated into the normal node process)

@kapouer
Copy link
Contributor

kapouer commented Mar 30, 2022

FYI just built nodejs 16.14.2 for debian on riscv64: all message parallel sequential tests pass except test-perf-hooks-histogram.js.
the log is here.

@mhdawson
Copy link
Member

mhdawson commented Apr 7, 2022

Description of Experimental - Experimental: May not compile or test suite may not pass. The core team does not create releases for these platforms. Test failures on experimental platforms do not block releases. Contributions to improve support for these platforms are welcome.

We could probably come up with a better name than Experimental, but it does seem to imply that a less than complete implementation is possible.

Having said that would also be happy if we wait for an unofficial build is in place so that we have confidence that it is far enough along that adding it makes sense.

@richardlau
Copy link
Member

Having said that would also be happy if we wait for an unofficial build is in place so that we have confidence that it is far enough along that adding it makes sense.

FWIW @sxa opened nodejs/unofficial-builds#54 a week ago.

@sxa
Copy link
Member

sxa commented Apr 8, 2022

Currently blocked on nodejs/unofficial-builds#55

@olof-nord
Copy link

Currently blocked on nodejs/unofficial-builds#55

With the linked issue closed in May this year, I understand this PR can be merged?
Ping @sxa as you linked the closed issue.

@aduh95
Copy link
Contributor

aduh95 commented Sep 20, 2023

@nodejs/build what's the status here? If we still want to merge this, it should be rebased to fix the conflicts.

@targos
Copy link
Member

targos commented Sep 20, 2023

I agree with @rvagg that without a @nodejs/platform-riscv team, this doesn't make much sense. We need someone to provide the experimental support.

@sxa
Copy link
Member

sxa commented Sep 20, 2023

I agree with @rvagg that without a @nodejs/platform-riscv team, this doesn't make much sense. We need someone to provide the experimental support.

I guess that's down to whether @luyahan is willing to provide such support going forward. I'd certainly want to be part of such a platform team if it exists but can't commit to supporting it on an ongoing basis ...

For what it's worth I do have https://ci.nodejs.org/job/sxa-rvnodetest which is running a regular build+test cycle on the platform on the v21 codebase, but there are test case failures in there so it's not ready for a push to integrate into the main node-test-commit set of platforms (unless it was made optional like Windows/arm was for a while)

@targos targos added the riscv64 Issues and PRs related to the riscv64 architecture. label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. riscv64 Issues and PRs related to the riscv64 architecture.
Projects
None yet
Development

Successfully merging this pull request may close these issues.