Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix syntax error not showing in stderr with node --inspect-brk #42486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/inspector_agent.cc
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,6 @@ void Agent::ReportUncaughtException(Local<Value> error,
if (!IsListening())
return;
client_->ReportUncaughtException(error, message);
WaitForDisconnect();
}

void Agent::PauseOnNextJavascriptStatement(const std::string& reason) {
Expand Down
30 changes: 30 additions & 0 deletions test/parallel/test-inspector-inspect-brk-error-report.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
'use strict';
const common = require('../common');
const assert = require('assert');

common.skipIfInspectorDisabled();

const { NodeInstance } = require('../common/inspector-helper.js');

async function runTest() {
const child = new NodeInstance(['--inspect-brk'], 'console.log(1');
const session = await child.connectInspectorSession();
await session.send({ method: 'Runtime.enable' });
await session.send({ method: 'Debugger.enable' });
await session.send({ method: 'Runtime.runIfWaitingForDebugger' });
let match = false;
while (true) {
const stderr = await child.nextStderrString();
if (/SyntaxError: missing \) after argument list/.test(stderr)) {
match = true;
}
if (/Waiting for the debugger to disconnect/.test(stderr)) {
break;
}
}
assert.ok(match);
await session.disconnect();
return child.expectShutdown();
}

runTest().then(common.mustCall());