-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: fix webcrypto derive key lengths #42542
Merged
nodejs-github-bot
merged 1 commit into
nodejs:master
from
panva:fix-webcrypto-derive-lengths
Apr 2, 2022
Merged
crypto: fix webcrypto derive key lengths #42542
nodejs-github-bot
merged 1 commit into
nodejs:master
from
panva:fix-webcrypto-derive-lengths
Apr 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
labels
Mar 31, 2022
panva
added
webcrypto
experimental
Issues and PRs related to experimental features.
labels
Mar 31, 2022
Prior to this code in place the following, which works in the browser const alice = await crypto.subtle.generateKey({ name: 'ECDH', namedCurve: 'P-256' }, false, ['deriveKey']);
const bob = await crypto.subtle.generateKey({ name: 'ECDH', namedCurve: 'P-256' }, false, ['deriveKey']);
const alice_ecdh_params = { name: 'ECDH', public: bob.publicKey };
const alice_shared_key = await crypto.subtle.deriveKey(alice_ecdh_params, alice.privateKey, 'HKDF', false, ['deriveKey']); Failed in Node.js with
Because the length passed to |
Trott
approved these changes
Apr 1, 2022
panva
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Apr 1, 2022
tniessen
approved these changes
Apr 2, 2022
panva
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 2, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 2, 2022
Landed in 18bd02f |
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 5, 2022
PR-URL: nodejs#42542 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
juanarbol
pushed a commit
that referenced
this pull request
Apr 6, 2022
PR-URL: #42542 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
PR-URL: nodejs#42542 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42542 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42542 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
PR-URL: #42542 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42542 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42542 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
crypto
Issues and PRs related to the crypto subsystem.
experimental
Issues and PRs related to experimental features.
needs-ci
PRs that need a full CI run.
webcrypto
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
get key length
operation of possiblederiveKey
derived key's algorithms.Specifically, for
AES Keys
PBKDF2 and HKDF Keys
HMAC Keys