feat: remove experimental warning from FormData #42807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
jasnell
approved these changes
Apr 21, 2022
targos
approved these changes
Apr 21, 2022
aduh95
approved these changes
Apr 21, 2022
aduh95
added
the
author ready
Mesteery
approved these changes
Apr 21, 2022
BethGriggs
approved these changes
Apr 21, 2022
panva
approved these changes
Apr 21, 2022
marsonya
approved these changes
Apr 22, 2022
This was referenced Apr 22, 2022
meixg
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5ad47a0 |
There was a problem hiding this comment.
Just reviewed this one and looks good to me! Per @meixg's question in the PR description:
"Is this change need a test? Do we have a way to assert a warning is not output?"
I think we could add a test like this:
// test/parallel/test-fetch-global-non-experimental.mjs
import * as common from '../common/index.mjs';
globalThis.Response;
globalThis.Headers;
globalThis.Request;
globalThis.Response;
globalThis.fetch;
// Only calling the global `fetch` function should result in an
// `ExperimentalWarning` being emitted.
process.on('warning', common.mustCall(0));I'm happy to open a PR to contribute the test if we think having it is valuable! Thoughts?
16 tasks
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
fixes: nodejs#42792 PR-URL: nodejs#42807 Fixes: nodejs#42792 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
This was referenced Apr 26, 2022
targos
pushed a commit
that referenced
this pull request
Apr 28, 2022
fixes: #42792 PR-URL: #42807 Fixes: #42792 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
|
This depends on #41811 which is not landed in v16.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #42792
Only output experimental warning when calling fetch.
Accessing
FormData,Headers,Request,Responsewill not output a warning.Is this change need a test? Do we have a way to assert a warning is not output?