test: fix flaky HTTP server tests #42846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
21 tasks
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Trott
approved these changes
Apr 24, 2022
lpinca
approved these changes
Apr 24, 2022
VoltrexKeyva
approved these changes
Apr 24, 2022
tniessen
added
the
author ready
|
The |
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
RaisinTen
approved these changes
Apr 24, 2022
I wasn't aware of the open issue. Edited the description in the hope that this will fix the flakiness. |
ShogunPanda
approved these changes
Apr 24, 2022
tniessen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0288844 |
16 tasks
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Refs: nodejs#41263 PR-URL: nodejs#42846 Fixes: nodejs#42741 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
This was referenced Apr 26, 2022
|
@tniessen this doesn't land cleanly in v16.x-staging - do you mind backporting this to v16.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two tests have been causing lots of CI failures, both in Jenkins and GitHub actions. They incorrectly use
common.platformTimeout(), which scales a given amount of time by a factor that depends on the platform. However, these tests compute some times ascommon.platformTimeout(x * common.platformTimeout(y)), effectively squaring the platform-dependent factor.I also increased the base timeout from 1000ms to 2000ms. As a reference, I ran one of the tests (
test-http-server-headers-timeout-keepalive.js) with different base timeouts, 8000 times each, using 200 concurrent processes across 16 cores.Refs: #41263
Fixes: #42741