Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use serial comma in util docs #43063

Merged
merged 1 commit into from
May 12, 2022
Merged

doc: use serial comma in util docs #43063

merged 1 commit into from
May 12, 2022

Conversation

tniessen
Copy link
Member

node/doc/README.md

Line 21 in 5e9274a

* [Use serial commas][].

Refs: #11321
Refs: #17384

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label May 12, 2022
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels May 12, 2022
@tniessen tniessen removed the fast-track PRs that do not need to wait for 48 hours to land. label May 12, 2022
@tniessen
Copy link
Member Author

Fast-track action failed, presumably a GitHub error:

2022-05-12T00:28:46.4933267Z ##[group]Run gh pr comment 43063 --repo nodejs/node --body "$FAST_TRACK_MESSAGE"
2022-05-12T00:28:46.4933865Z �[36;1mgh pr comment 43063 --repo nodejs/node --body "$FAST_TRACK_MESSAGE"�[0m
2022-05-12T00:28:46.5503993Z shell: /usr/bin/bash -e {0}
2022-05-12T00:28:46.5504881Z env:
2022-05-12T00:28:46.5506415Z   STALE_MESSAGE: This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

2022-05-12T00:28:46.5508336Z   FAST_TRACK_MESSAGE: Fast-track has been requested by @tniessen. Please 👍 to approve.
2022-05-12T00:28:46.5510126Z   GITHUB_TOKEN: ***
2022-05-12T00:28:46.5510847Z ##[endgroup]
2022-05-12T00:28:46.9564878Z HTTP 500 (https://api.github.com/graphql)
2022-05-12T00:28:46.9587111Z ##[error]Process completed with exit code 1.
2022-05-12T00:28:46.9828084Z Cleaning up orphan processes

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label May 12, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 12, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43063
✔  Done loading data for nodejs/node/pull/43063
----------------------------------- PR info ------------------------------------
Title      doc: use serial comma in util docs (#43063)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     tniessen:doc-serial-comma-util -> nodejs:master
Labels     util, doc, fast-track
Commits    1
 - doc: use serial comma in util docs
Committers 1
 - Tobias Nießen 
PR-URL: https://github.com/nodejs/node/pull/43063
Refs: https://github.com/nodejs/node/pull/11321
Refs: https://github.com/nodejs/node/pull/17384
Reviewed-By: Rich Trott 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Darshan Sen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43063
Refs: https://github.com/nodejs/node/pull/11321
Refs: https://github.com/nodejs/node/pull/17384
Reviewed-By: Rich Trott 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Darshan Sen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 12 May 2022 00:28:34 GMT
   ✔  Approvals: 3
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43063#pullrequestreview-970127656
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43063#pullrequestreview-970134049
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43063#pullrequestreview-971111627
   ℹ  This PR is being fast-tracked
   ✖  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2315851490

@tniessen tniessen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 12, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 12, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43063
✔  Done loading data for nodejs/node/pull/43063
----------------------------------- PR info ------------------------------------
Title      doc: use serial comma in util docs (#43063)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     tniessen:doc-serial-comma-util -> nodejs:master
Labels     util, doc, fast-track
Commits    1
 - doc: use serial comma in util docs
Committers 1
 - Tobias Nießen 
PR-URL: https://github.com/nodejs/node/pull/43063
Refs: https://github.com/nodejs/node/pull/11321
Refs: https://github.com/nodejs/node/pull/17384
Reviewed-By: Rich Trott 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Darshan Sen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43063
Refs: https://github.com/nodejs/node/pull/11321
Refs: https://github.com/nodejs/node/pull/17384
Reviewed-By: Rich Trott 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Darshan Sen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 12 May 2022 00:28:34 GMT
   ✔  Approvals: 3
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43063#pullrequestreview-970127656
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43063#pullrequestreview-970134049
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43063#pullrequestreview-971111627
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2316043100

@tniessen
Copy link
Member Author

The first failed fast-track GitHub Action seems to have messed things up... I am going to delete the second automated fast-track comment and see if that helps.

@nodejs nodejs deleted a comment from github-actions bot May 12, 2022
@tniessen tniessen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 12, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 12, 2022
@nodejs-github-bot nodejs-github-bot merged commit 5e6f9c3 into nodejs:master May 12, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 5e6f9c3

BethGriggs pushed a commit that referenced this pull request May 16, 2022
@tniessen @BethGriggs
doc: use serial comma in util docs
76096c2 
Refs: #11321
Refs: #17384

PR-URL: #43063
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 16, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@tniessen @juanarbol
doc: use serial comma in util docs
084a760 
Refs: #11321
Refs: #17384

PR-URL: #43063
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@tniessen @danielleadams
doc: use serial comma in util docs
371341b 
Refs: #11321
Refs: #17384

PR-URL: #43063
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@tniessen @targos
doc: use serial comma in util docs
1df3864 
Refs: #11321
Refs: #17384

PR-URL: #43063
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@tniessen @targos
doc: use serial comma in util docs
0eb8c46 
Refs: #11321
Refs: #17384

PR-URL: #43063
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@tniessen @guangwong
doc: use serial comma in util docs
4939899 
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43063
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tniessen @nodejs-github-bot @Trott @RaisinTen @VoltrexKeyva