Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf_hooks: fix miscounted gc performance entry starttime #43066

Merged
merged 2 commits into from
Jun 17, 2022
Merged

perf_hooks: fix miscounted gc performance entry starttime #43066

merged 2 commits into from
Jun 17, 2022

Conversation

meixg
Copy link
Member

@meixg meixg commented May 12, 2022

fixes: #43062

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 12, 2022
@lpinca lpinca mentioned this pull request May 12, 2022
Closed
4 tasks
@meixg meixg added the request-ci Add this label to start a Jenkins CI on a PR. label May 13, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 13, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43987/

This was referenced May 14, 2022
Open
Open
Open
Open
Open
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44072/

@github-actions github-actions bot mentioned this pull request May 19, 2022
Open
27 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44075/

@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 19, 2022
This was referenced May 20, 2022
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44119/

@github-actions github-actions bot mentioned this pull request May 23, 2022
Open
20 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44141/

This was referenced May 24, 2022
Open
Open
Open
Open
Open
@meixg meixg added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44415/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44462/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44473/

@github-actions github-actions bot mentioned this pull request Jun 13, 2022
Open
15 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44489/

@github-actions github-actions bot mentioned this pull request Jun 14, 2022
Open
16 tasks
@meixg meixg added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 14, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43066
✔  Done loading data for nodejs/node/pull/43066
----------------------------------- PR info ------------------------------------
Title      perf_hooks: fix miscounted gc performance entry starttime (#43066)
Author     Xuguang Mei  (@meixg)
Branch     meixg:perf-hooks-gc-time-meixg -> nodejs:master
Labels     c++, author ready, needs-ci, commit-queue-squash
Commits    2
 - perf_hooks: fix miscounted gc performance entry starttime
 - perf_hooks: fix miscounted gc performance entry starttime
Committers 1
 - meixg 
PR-URL: https://github.com/nodejs/node/pull/43066
Fixes: https://github.com/nodejs/node/issues/43062
Reviewed-By: Chengzhong Wu 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43066
Fixes: https://github.com/nodejs/node/issues/43062
Reviewed-By: Chengzhong Wu 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 12 May 2022 05:17:12 GMT
   ✔  Approvals: 2
   ✔  - Chengzhong Wu (@legendecas): https://github.com/nodejs/node/pull/43066#pullrequestreview-971910628
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/43066#pullrequestreview-1003513114
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2022-06-13T14:18:27Z: https://ci.nodejs.org/job/node-test-pull-request/44489/
- Querying data for job/node-test-pull-request/44489/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2492556784

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jun 14, 2022
@meixg
Copy link
Member Author

meixg commented Jun 14, 2022

✖ Last GitHub CI failed

Looks like the commit-queue label had a problem with GitHub CI checking, should I land this manually?

@github-actions github-actions bot mentioned this pull request Jun 15, 2022
Open
17 tasks
@aduh95 aduh95 merged commit 7f19518 into nodejs:main Jun 17, 2022
@aduh95
Copy link
Contributor

aduh95 commented Jun 17, 2022

Landed in 7f19518

@meixg meixg deleted the perf-hooks-gc-time-meixg branch June 17, 2022 08:30
targos pushed a commit that referenced this pull request Jul 12, 2022
@meixg @targos
perf_hooks: fix miscounted gc performance entry starttime (#43066)
02009b7 
PR-URL: #43066
Fixes: #43062
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 18, 2022
@meixg @targos
perf_hooks: fix miscounted gc performance entry starttime (#43066)
97ac249 
PR-URL: #43066
Fixes: #43062
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@meixg @targos
perf_hooks: fix miscounted gc performance entry starttime (#43066)
096a2d9 
PR-URL: #43066
Fixes: #43062
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@meixg @guangwong
perf_hooks: fix miscounted gc performance entry starttime (#43066)
f87ed19 
PR-URL: nodejs/node#43066
Fixes: nodejs/node#43062
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gc performance entries report incorrect startTime
5 participants
@meixg @nodejs-github-bot @aduh95 @jasnell @legendecas