Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: temp disable windows-2022 #43093

Merged
merged 1 commit into from
May 14, 2022
Merged

Conversation

gengjiawen
Copy link
Member

re-enable if #43092 is fixed.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 14, 2022
@gengjiawen gengjiawen added the fast-track PRs that do not need to wait for 48 hours to land. label May 14, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @gengjiawen. Please 👍 to approve.

@tniessen
Copy link
Member

@LiviaMedeiros You approved the fast-tracking request but not the PR, but fast-tracking is only considered for PRs that have at least two approvals. I'm only mentioning it in case it wasn't intentional :)

PR-URL: nodejs#43093
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott force-pushed the disable_win2022_temp branch from e4f4186 to 8c800d7 Compare May 14, 2022 15:50
@Trott Trott merged commit 8c800d7 into nodejs:master May 14, 2022
@Trott
Copy link
Member

Trott commented May 14, 2022

Landed in 8c800d7.

@gengjiawen gengjiawen deleted the disable_win2022_temp branch May 15, 2022 02:58
BethGriggs pushed a commit that referenced this pull request May 16, 2022
PR-URL: #43093
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 16, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #43093
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants