-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: use serial comma in fs docs #43104
Conversation
Fast-track has been requested by @tniessen. Please 👍 to approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits, feel free to ignore or leave for later:
Line 1562 in 4d5bbc7
`data` can be a string, a buffer, an {AsyncIterable} or {Iterable} object. |
Line 1687 in 4d5bbc7
`fs.open()`, `fs.readFile()` or `fs.writeFile()`. Doing |
Line 2412 in 4d5bbc7
`fs.open()`, `fs.readFile()` or `fs.writeFile()` is not recommended. Doing |
Line 3876 in 4d5bbc7
`fs.open()`, `fs.readFile()` or `fs.writeFile()` is not recommended. |
Line 7524 in 4d5bbc7
through `fs.open()` or `fs.writeFile()` or `fsPromises.open()`) will fail with |
Out of curiosity, maybe comma should be used in those as well, since any TypedArray
is equivalent of Int8Array, ..., or Float64Array
:
Lines 4395 to 4396 in 4d5bbc7
description: The `buffer` parameter can now be any `TypedArray` or a | |
`DataView`. |
1238886
to
d9a91c4
Compare
Thanks @LiviaMedeiros, I missed those! Force-pushed, the actual diff since the first commit is 1238886. PTAL. |
cf0fb14
to
4aac703
Compare
Thanks for catching that @LiviaMedeiros! Force-pushed again, the actual diff is cf0fb14. |
Landed in d1d30d7 |
Refs: nodejs/node#11321 Refs: nodejs/node#17384 PR-URL: nodejs/node#43104 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
node/doc/README.md
Line 21 in 5e9274a
Refs: #11321
Refs: #17384