Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix json utils escapes for U+000B #43206

Closed
wants to merge 1 commit into from
Closed

src: fix json utils escapes for U+000B #43206

wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented May 25, 2022 •
edited
Loading

According to the https://www.ecma-international.org/wp-content/uploads/ECMA-404_2nd_edition_december_2017.pdf section 9 String, there are only the following two-character escape sequences:

  • \" represents the quotation mark character (U+0022).
  • \\ represents the reverse solidus character (U+005C).
  • \/ represents the solidus character (U+002F).
  • \b represents the backspace character (U+0008).
  • \f represents the form feed character (U+000C).
  • \n represents the line feed character (U+000A).
  • \r represents the carriage return character (U+000D).
  • \t represents the character tabulation character (U+0009).

\v is not one of them. So it should be escaped with hexadecimal sequence.

Fixes: #43193

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 25, 2022
@legendecas legendecas marked this pull request as ready for review May 25, 2022 15:37
@legendecas legendecas requested a review from addaleax May 26, 2022 14:58
mhdawson
mhdawson approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44196/

This was referenced May 28, 2022
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44243/

@github-actions github-actions bot mentioned this pull request May 31, 2022
Open
16 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44250/

@github-actions github-actions bot mentioned this pull request Jun 1, 2022
Open
17 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44271/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44297/

@github-actions github-actions bot mentioned this pull request Jun 2, 2022
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44319/

This was referenced Jun 3, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44371/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44382/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44384/

@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 10, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44420/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44424/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44464/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44468/

@github-actions github-actions bot mentioned this pull request Jun 13, 2022
Open
15 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44480/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44505/

@github-actions github-actions bot mentioned this pull request Jun 14, 2022
Open
16 tasks
legendecas added a commit that referenced this pull request Jun 14, 2022
@legendecas
src: fix json utils escapes for U+000B
486dcd7 
PR-URL: #43206
Fixes: #43193
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@legendecas
Copy link
Member Author

Landed in 486dcd7

@legendecas legendecas closed this Jun 14, 2022
@legendecas legendecas deleted the issue-43193 branch June 14, 2022 03:56
danielleadams pushed a commit that referenced this pull request Jun 14, 2022
@legendecas @danielleadams
src: fix json utils escapes for U+000B
a056840 
PR-URL: #43206
Fixes: #43193
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 14, 2022
Merged
@github-actions github-actions bot mentioned this pull request Jun 15, 2022
Open
17 tasks
targos pushed a commit that referenced this pull request Jul 12, 2022
@legendecas @targos
src: fix json utils escapes for U+000B
fbe35e3 
PR-URL: #43206
Fixes: #43193
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@legendecas @targos
src: fix json utils escapes for U+000B
094d5fc 
PR-URL: #43206
Fixes: #43193
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
@jonaldinger jonaldinger mentioned this pull request Aug 18, 2022
Closed
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@legendecas @guangwong
src: fix json utils escapes for U+000B
e2a80f9 
PR-URL: nodejs/node#43206
Fixes: nodejs/node#43193
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tony-go tony-go tony-go approved these changes

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

@JungMinu JungMinu JungMinu approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON Parse error in internal/process/report?
7 participants
@legendecas @nodejs-github-bot @jasnell @JungMinu @richardlau @mhdawson @tony-go