tools: update clang-format 1.7.0 to 1.8.0 #43241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel and M1 Macs. Signed-off-by: Darshan Sen <raisinten@gmail.com>
tniessen
approved these changes
May 29, 2022
RaisinTen
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
Trott
approved these changes
May 29, 2022
This comment was marked as outdated.
This comment was marked as outdated.
VoltrexKeyva
approved these changes
May 29, 2022
This comment was marked as outdated.
This comment was marked as outdated.
18 tasks
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
May 30, 2022
This was referenced May 31, 2022
tniessen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7a71ae8 |
This was referenced Jun 2, 2022
italojs
pushed a commit
to italojs/node
that referenced
this pull request
Jun 6, 2022
v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel and M1 Macs. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#43241 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 11, 2022
v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel and M1 Macs. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43241 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel and M1 Macs. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43241 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel and M1 Macs. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43241 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel and M1 Macs. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43241 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel and M1 Macs. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs/node#43241 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.7.0 was shipping ARM64 binaries for macOS which doesn't run on Intel
Macs. v1.8.0 moved back to x86_64 binaries which works on both Intel
and M1 Macs.
Signed-off-by: Darshan Sen raisinten@gmail.com