-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: delete llnode
from diagnostic tooling support tiers
#43289
doc: delete llnode
from diagnostic tooling support tiers
#43289
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
0051d50
to
08d80cf
Compare
/cc @mmarchini |
cc @nodejs/llnode |
I'm actually not sure if it makes sense to remove it.
@gireeshpunathil I believe you found a volunteer? |
Speaking as someone who used to do some maintenance work on llnode - I don’t think it’s now maintained enough to be considered supported, I do sometimes miss it when I need to grok V8 coredumps or certain kinds of crashed V8 processes, though sadly I don’t think I currently have the bandwidth to keep it in shape either.. |
Yes, but given the time to ramp up, I think it makes sense to take it off the list as of now, and add it back at a later point when we think it is sufficiently maintained? |
@tony-go can you please remove the merge commit? |
9bdb47e
to
17c8d24
Compare
cc @lpinca |
I would also be interested in contributing when I can as I use it regularly. I don't have much bandwidth so don't want to be the only person on it, but if there's any calls happening to get others up to speed, please invite me too. |
I also offer my help during the last WG meeting. Definitely not familiar with this kind of project, but it's surely a good opportunity to learn ^^ |
Landed in 4f3b8fa |
PR-URL: #43289 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #43289 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #43289 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs/node#43289 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Hey node family 👋
Context
The diagnostic working group currently works on an initiative to re-evaluate the diagnostic tooling list and its maturity.
Updated
In the previous instance, we examined the case of the
llnode
module: issue link.It seems that we don't have a clear idea about the current status of this tool. Until we can clarify the status of this tool, we prefer to remove it from the list.
In parallel, @gireeshpunathil will try to contact potential contributors to see how could we fill the gap.
Discuss
As usual, feel free to share your thoughts on that and your experience with this tool.
With love ❤️
cc @nodejs/diagnostics