Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: test webcrypto ec raw public key import #43405

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

panva
Copy link
Member

@panva panva commented Jun 13, 2022

Adds tests for raw public EC key imports (both compressed and uncompressed).

@panva panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. experimental Issues and PRs related to experimental features. webcrypto labels Jun 13, 2022
@panva panva requested review from jasnell and tniessen June 13, 2022 13:22
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 13, 2022
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2022
@nodejs-github-bot

This comment was marked as outdated.

Buffer.alloc(1, 0x04),
Buffer.from(jwk.x, 'base64url'),
Buffer.from(jwk.y, 'base64url'),
]),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note... It would be nice if Web Crypto supported using Blob for this kind of stuff.

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 13, 2022
Buffer.concat([
Buffer.alloc(1, 0x04),
Buffer.from(jwk.x, 'base64url'),
Buffer.from(jwk.y, 'base64url'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For hard-coded encoding/decoding mechanisms, it's usually a good idea to add a comment with a reference to a resource defining the relevant encoding.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44522/

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 15, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 15, 2022
@nodejs-github-bot nodejs-github-bot merged commit 6a7aff6 into nodejs:master Jun 15, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 6a7aff6

danielleadams pushed a commit that referenced this pull request Jun 16, 2022
PR-URL: #43405
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Jun 16, 2022
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43405
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43405
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43405
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@panva panva deleted the crypto-test-ec-raw-import branch October 13, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. webcrypto
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants