Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use platformTimeout() in more places #4387

Closed
wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Dec 22, 2015

Without these changes, the pi1-raspbian-wheezy CI node was timing out on these tests.

Without these changes, the pi1-raspbian-wheezy CI node was timing
out on these tests.
@mscdex mscdex added test Issues and PRs related to the tests. arm Issues and PRs related to the ARM platform. http Issues or PRs related to the http subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. labels Dec 22, 2015
@bnoordhuis
Copy link
Member

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Dec 22, 2015

LGTM

mscdex added a commit that referenced this pull request Dec 22, 2015
Without these changes, the pi1-raspbian-wheezy CI node was timing
out on these tests.

PR-URL: #4387
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@mscdex
Copy link
Contributor Author

mscdex commented Dec 22, 2015

Landed in d847a74.

@mscdex mscdex closed this Dec 22, 2015
@mscdex mscdex deleted the fix-arm-test-timeouts branch December 22, 2015 20:07
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
Without these changes, the pi1-raspbian-wheezy CI node was timing
out on these tests.

PR-URL: nodejs#4387
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
mscdex added a commit that referenced this pull request Jan 7, 2016
Without these changes, the pi1-raspbian-wheezy CI node was timing
out on these tests.

PR-URL: #4387
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Without these changes, the pi1-raspbian-wheezy CI node was timing
out on these tests.

PR-URL: #4387
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Without these changes, the pi1-raspbian-wheezy CI node was timing
out on these tests.

PR-URL: nodejs#4387
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. dgram Issues and PRs related to the dgram subsystem / UDP. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants