Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unnecessary cast in crypto_sig.cc #44001

Merged
merged 1 commit into from
Jul 27, 2022
Merged

src: remove unnecessary cast in crypto_sig.cc #44001

merged 1 commit into from
Jul 27, 2022

Conversation

tniessen
Copy link
Member

ByteSource::Allocated accepts a void pointer now, so we do not need to cast the argument to a char pointer.

Refs: #43202

@tniessen
src: remove unnecessary cast in crypto_sig.cc
d9aaf23 
ByteSource::Allocated accepts a void pointer now, so we do not need to
cast the argument to a char pointer.

Refs: nodejs#43202
@tniessen tniessen added c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 26, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jul 26, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 26, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45694/

@github-actions github-actions bot mentioned this pull request Jul 27, 2022
Open
16 tasks
@F3n67u F3n67u added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 27, 2022
@RaisinTen RaisinTen removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 27, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45698/

@RaisinTen
Copy link
Contributor

RaisinTen commented Jul 27, 2022 •
edited
Loading

@F3n67u did you mean to apply commit-queue instead of request-ci (because the last CI was a passing one already)?

@F3n67u
Copy link
Member

F3n67u commented Jul 27, 2022

@F3n67u did you mean to apply commit-queue instead of request-ci (because the last CI was a passing one already)?

@RaisinTen sorry. I don't see there is already a ci run

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 27, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 27, 2022
@nodejs-github-bot nodejs-github-bot merged commit abddacb into nodejs:main Jul 27, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in abddacb

This was referenced Aug 1, 2022
Open
Open
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
@tniessen @danielleadams
src: remove unnecessary cast in crypto_sig.cc
2c44730 
ByteSource::Allocated accepts a void pointer now, so we do not need to
cast the argument to a char pointer.

Refs: #43202

PR-URL: #44001
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
@danielleadams danielleadams mentioned this pull request Aug 16, 2022
Closed
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
@tniessen @ruyadorno
src: remove unnecessary cast in crypto_sig.cc
4603977 
ByteSource::Allocated accepts a void pointer now, so we do not need to
cast the argument to a char pointer.

Refs: #43202

PR-URL: #44001
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
@ruyadorno ruyadorno mentioned this pull request Aug 23, 2022
Merged
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@tniessen @Fyko
src: remove unnecessary cast in crypto_sig.cc
41264b0 
ByteSource::Allocated accepts a void pointer now, so we do not need to
cast the argument to a char pointer.

Refs: nodejs#43202

PR-URL: nodejs#44001
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@F3n67u F3n67u F3n67u approved these changes

@panva panva panva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @nodejs-github-bot @RaisinTen @F3n67u @panva @targos