Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16.x backport] deps: V8: backport 22698d267667 #44085

Closed

Commits on Aug 1, 2022

  1. deps: V8: backport 22698d267667

    Original commit message:
    
        [module] Fix aborts in terminated async module evaluation
    
        SourceTextModule::ExecuteAsyncModule asserts the execution of
        the module's async function to succeed without exception. However,
        the problem is that TerminateExecution initiated by embedders is
        breaking that assumption. The execution can be terminated with an
        exception and the exception is not catchable by JavaScript.
    
        The uncatchable exceptions during the async module evaluation need
        to be raised to the embedder and not crash the process if possible.
    
        Refs: nodejs#43182
    
        Change-Id: Ifc152428b95945b6b49a2f70ba35018cfc0ce40b
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3696493
        Reviewed-by: Camillo Bruni <cbruni@chromium.org>
        Commit-Queue: Chengzhong Wu <legendecas@gmail.com>
        Cr-Commit-Position: refs/heads/main@{#81307}
    
    Refs: v8/v8@22698d2
    
    PR-URL: nodejs#43751
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    legendecas committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    682bff6 View commit details
    Browse the repository at this point in the history
  2. test: add test on worker process.exit in async modules

    PR-URL: nodejs#43751
    Refs: v8/v8@22698d2
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    legendecas committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    c2b56f7 View commit details
    Browse the repository at this point in the history