repl: save repl session in file #442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is for #394 to begin discussion. |
rvagg
added
the
semver-minor
|
|
||
| function ReadlineFileHistory(options) { | ||
| if (!path) path = require('path'); | ||
| if (!fs) fs = require('fs'); |
There was a problem hiding this comment.
I don't see any benefit to lazy loading these modules. Could you hoist this declaration to the top?
Extract history in separate function to manage it all in one place as a result add subclass that write entries to file (by default ~/.iojs_history). Also allow to disable history write via env variable NODE_DISABLE_HISTORY.
|
@brendanashworth fixed. |
|
I'm in favour of #596 |
|
Closing per #394 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract history in separate function to manage it all in one place
as a result add subclass that write entries to file (by default ~/.iojs_history)