Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x backport] test runner additions #44873

Closed
wants to merge 6 commits into from
Closed

[v16.x backport] test runner additions #44873

wants to merge 6 commits into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Oct 3, 2022 •
edited
Loading

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@MoLow MoLow changed the base branch from main to v16.x-staging October 3, 2022 10:07
@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Oct 3, 2022
@targos
Copy link
Member

targos commented Oct 3, 2022

If possible, we prefer to keep separated commits in backports, so we know from the git log what landed in the release line

MoLow added a commit to MoLow/node that referenced this pull request Oct 3, 2022
@MoLow
test_runner: support programmatically running --test
f89b1ad 
PR-URL: nodejs#44241
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44023
Fixes: nodejs#43675
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Oct 3, 2022
@MoLow
test_runner: fix duration_ms to be milliseconds
56ab06c 
PR-URL: nodejs#44450
Backport-PR-URL: nodejs#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Oct 3, 2022
@MoLow
test_runner: support using --inspect with --test
e3c3e60 
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow MoLow force-pushed the backport-v16-test-runner branch from b6d316e to f44fcd9 Compare October 3, 2022 10:15
MoLow added a commit to MoLow/node that referenced this pull request Oct 3, 2022
@MoLow
test_runner: include stack of uncaught exceptions
19efff7 
PR-URL: nodejs#44614
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44611
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Oct 3, 2022
@MoLow
test: fix test-runner-inspect
f44fcd9 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow
Copy link
Member Author

MoLow commented Oct 3, 2022

@targos I am not sure what you meant - but you commented before I have committed. I just wanted to have a backport pr URL before cherry-picking the relevant commits.
is the PR ok now?

@MoLow MoLow marked this pull request as ready for review October 3, 2022 10:16
@targos
Copy link
Member

targos commented Oct 3, 2022

@MoLow Looks like I was too fast indeed. This looks ok 👍🏻 (btw, you can add the Backport-PR-URL yourself, but that would be already done automatically when we land it with git-node land --backport)

MoLow added a commit to MoLow/node that referenced this pull request Oct 3, 2022
@MoLow
test_runner: support programmatically running --test
1760edd 
PR-URL: nodejs#44241
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44023
Fixes: nodejs#43675
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Oct 3, 2022
@MoLow
test_runner: fix duration_ms to be milliseconds
fb41b39 
PR-URL: nodejs#44450
Backport-PR-URL: nodejs#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@MoLow MoLow force-pushed the backport-v16-test-runner branch from f44fcd9 to d351059 Compare October 3, 2022 11:31
MoLow added a commit to MoLow/node that referenced this pull request Oct 3, 2022
@MoLow
test_runner: support using --inspect with --test
e2fe4f1 
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Oct 3, 2022
@MoLow
test_runner: include stack of uncaught exceptions
d02572c 
PR-URL: nodejs#44614
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44611
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Oct 3, 2022
@MoLow
test: fix test-runner-inspect
d351059 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow MoLow added the v16.x label Oct 3, 2022
@MoLow
Copy link
Member Author

MoLow commented Oct 3, 2022

v16 linter seems broken regardless of this PR

@MoLow MoLow added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Oct 3, 2022
MoLow added a commit to MoLow/node that referenced this pull request Oct 3, 2022
@MoLow
test_runner: support programmatically running --test
0701ab9 
PR-URL: nodejs#44241
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44023
Fixes: nodejs#43675
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Oct 3, 2022
@MoLow
test_runner: fix duration_ms to be milliseconds
18d3839 
PR-URL: nodejs#44450
Backport-PR-URL: nodejs#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@MoLow MoLow force-pushed the backport-v16-test-runner branch from d351059 to 23ab7fe Compare October 3, 2022 13:08
MoLow added a commit to MoLow/node that referenced this pull request Oct 3, 2022
@MoLow
test_runner: support using --inspect with --test
c5db7f0 
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Oct 3, 2022
@MoLow
test_runner: include stack of uncaught exceptions
d445f84 
PR-URL: nodejs#44614
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44611
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Oct 3, 2022
@MoLow
test: fix test-runner-inspect
23ab7fe 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44873
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos
Copy link
Member

targos commented Oct 3, 2022 •
edited
Loading

v16 linter seems broken regardless of this PR

@juanarbol it seems to be broken since the last push to v16.x-staging

@github-actions github-actions bot mentioned this pull request Dec 1, 2022
Open
10 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48256/

@MoLow
Copy link
Member Author

MoLow commented Dec 1, 2022

@richardlau can this be merged?

This was referenced Dec 2, 2022
Open
Open
Open
Open
richardlau pushed a commit that referenced this pull request Dec 7, 2022
@MoLow @richardlau
test_runner: support programmatically running --test
37e9092 
PR-URL: #44241
Backport-PR-URL: #44873
Fixes: #44023
Fixes: #43675
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau pushed a commit that referenced this pull request Dec 7, 2022
@MoLow @richardlau
test_runner: fix duration_ms to be milliseconds
99ee5e4 
PR-URL: #44450
Backport-PR-URL: #44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
richardlau pushed a commit that referenced this pull request Dec 7, 2022
@MoLow @richardlau
test_runner: support using --inspect with --test
64d343a 
PR-URL: #44520
Backport-PR-URL: #44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau pushed a commit that referenced this pull request Dec 7, 2022
@MoLow @richardlau
test: fix test-runner-inspect
02a18ea 
PR-URL: #44620
Backport-PR-URL: #44873
Fixes: #44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau pushed a commit that referenced this pull request Dec 7, 2022
@MoLow @richardlau
cluster: use inspector utils
96d1316 
PR-URL: #44592
Backport-PR-URL: #44873
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
richardlau pushed a commit that referenced this pull request Dec 7, 2022
@pbo-linaro @richardlau
test: mark test-watch-mode* as flaky on all platforms
821d832 
This was confirmed flaky on those platforms:
- Windows x64
- Windows on Arm
- Linux
- Freebsd

Tests randomly fail because of bad order in messages expected, which
seems related to threads scheduling at execution.

PR-URL: #45049
Backport-PR-URL: #44873
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau
Copy link
Member

Landed in 5a776d4...821d832.

@richardlau richardlau closed this Dec 7, 2022
@github-actions github-actions bot mentioned this pull request Dec 8, 2022
Open
8 tasks
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test_runner: support programmatically running --test
26624ab 
PR-URL: nodejs/node#44241
Backport-PR-URL: nodejs/node#44873
Fixes: nodejs/node#44023
Fixes: nodejs/node#43675
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test_runner: fix duration_ms to be milliseconds
7528878 
PR-URL: nodejs/node#44450
Backport-PR-URL: nodejs/node#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test_runner: support using --inspect with --test
aa2e438 
PR-URL: nodejs/node#44520
Backport-PR-URL: nodejs/node#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test: fix test-runner-inspect
e34af51 
PR-URL: nodejs/node#44620
Backport-PR-URL: nodejs/node#44873
Fixes: nodejs/node#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
cluster: use inspector utils
20e4e60 
PR-URL: nodejs/node#44592
Backport-PR-URL: nodejs/node#44873
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@pbo-linaro @guangwong
test: mark test-watch-mode* as flaky on all platforms
8f26ee0 
This was confirmed flaky on those platforms:
- Windows x64
- Windows on Arm
- Linux
- Freebsd

Tests randomly fail because of bad order in messages expected, which
seems related to threads scheduling at execution.

PR-URL: nodejs/node#45049
Backport-PR-URL: nodejs/node#44873
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test_runner: support programmatically running --test
a0df862 
PR-URL: nodejs/node#44241
Backport-PR-URL: nodejs/node#44873
Fixes: nodejs/node#44023
Fixes: nodejs/node#43675
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test_runner: fix duration_ms to be milliseconds
b46081b 
PR-URL: nodejs/node#44450
Backport-PR-URL: nodejs/node#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test_runner: support using --inspect with --test
f77d7b7 
PR-URL: nodejs/node#44520
Backport-PR-URL: nodejs/node#44873
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
test: fix test-runner-inspect
2dcd0bf 
PR-URL: nodejs/node#44620
Backport-PR-URL: nodejs/node#44873
Fixes: nodejs/node#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@MoLow @guangwong
cluster: use inspector utils
2a9fa79 
PR-URL: nodejs/node#44592
Backport-PR-URL: nodejs/node#44873
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@pbo-linaro @guangwong
test: mark test-watch-mode* as flaky on all platforms
7a6fc92 
This was confirmed flaky on those platforms:
- Windows x64
- Windows on Arm
- Linux
- Freebsd

Tests randomly fail because of bad order in messages expected, which
seems related to threads scheduling at execution.

PR-URL: nodejs/node#45049
Backport-PR-URL: nodejs/node#44873
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MoLow MoLow deleted the backport-v16-test-runner branch May 24, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MoLow @nodejs-github-bot @targos @aduh95 @richardlau @pbo-linaro