Revert "http: do not leak error listeners" #44921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
http
This reverts commit 736a7d8. The patch attempted to fix an issue, signaled by a warning, caused by an invalid API usage. However it introduced a behavior change that is breaking userland modules. It is a user error, so restore the original behavior and have the user investigate and fix the issue in their code. Refs: nodejs#43587 (comment) Refs: nodejs#43587 (comment)
|
It might be better to add a test that document this. |
Ok, but in a follow up PR, possibly. This is only a revert. |
ronag
approved these changes
Oct 8, 2022
cjihrig
approved these changes
Oct 8, 2022
BethGriggs
approved these changes
Oct 9, 2022
bnb
approved these changes
Oct 10, 2022
Merged
lpinca
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/44921 ✔ Done loading data for nodejs/node/pull/44921 ----------------------------------- PR info ------------------------------------ Title Revert "http: do not leak error listeners" (#44921) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch lpinca:revert/736a7d8 -> nodejs:main Labels http, needs-ci Commits 1 - Revert "http: do not leak error listeners" Committers 1 - Luigi Pinca PR-URL: https://github.com/nodejs/node/pull/44921 Reviewed-By: Matteo Collina Reviewed-By: Robert Nagy Reviewed-By: Colin Ihrig Reviewed-By: Beth Griggs Reviewed-By: Tierney Cyren ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44921 Reviewed-By: Matteo Collina Reviewed-By: Robert Nagy Reviewed-By: Colin Ihrig Reviewed-By: Beth Griggs Reviewed-By: Tierney Cyren -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 08 Oct 2022 05:49:52 GMT ✔ Approvals: 5 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/44921#pullrequestreview-1135185005 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/44921#pullrequestreview-1135192504 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/44921#pullrequestreview-1135251333 ✔ - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/44921#pullrequestreview-1135400540 ✔ - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/44921#pullrequestreview-1136569280 ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3229727303 |
github-actions
bot
removed
the
request-ci
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7c06eab |
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
This reverts commit 736a7d8. The patch attempted to fix an issue, signaled by a warning, caused by an invalid API usage. However it introduced a behavior change that is breaking userland modules. It is a user error, so restore the original behavior and have the user investigate and fix the issue in their code. Refs: #43587 (comment) Refs: #43587 (comment) PR-URL: #44921 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
This reverts commit 736a7d8. The patch attempted to fix an issue, signaled by a warning, caused by an invalid API usage. However it introduced a behavior change that is breaking userland modules. It is a user error, so restore the original behavior and have the user investigate and fix the issue in their code. Refs: #43587 (comment) Refs: #43587 (comment) PR-URL: #44921 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 736a7d8.
The patch attempted to fix an issue, signaled by a warning, caused by an invalid API usage. However it introduced a behavior change that is breaking userland modules.
It is a user error, so restore the original behavior and have the user investigate and fix the issue in their code.
Refs: #43587 (comment)
Refs: #43587 (comment)