Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove unnecessary noop function args to mustCall() #45027

Merged
merged 1 commit into from
Oct 18, 2022
Merged

test: remove unnecessary noop function args to mustCall() #45027

merged 1 commit into from
Oct 18, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 16, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 16, 2022
@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. test Issues and PRs related to the tests. and removed test Issues and PRs related to the tests. async_hooks Issues and PRs related to the async hooks subsystem. needs-ci PRs that need a full CI run. labels Oct 16, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47288/

anonrig
anonrig approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aduh95
aduh95 reviewed Oct 16, 2022
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few missing occurrences, I think it would make sense to add a lint rule for that, the selector would be something like CallExpression:matches([callee.object.name="common"][callee.property.name="mustCall"],[callee.name="mustCall"])>:first-child[type="ArrowFunctionExpression"][body.body.length=0].

@Trott
Copy link
Member Author

Trott commented Oct 18, 2022

There are a few missing occurrences, I think it would make sense to add a lint rule for that, the selector would be something like CallExpression:matches([callee.object.name="common"][callee.property.name="mustCall"],[callee.name="mustCall"])>:first-child[type="ArrowFunctionExpression"][body.body.length=0].

Sounds good to me. I'll plan that for subsequent PR (or feel free to open one now if you'd prefer).

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Oct 18, 2022
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 18, 2022
aduh95 added a commit to aduh95/node that referenced this pull request Oct 18, 2022
@aduh95
test: remove unnecessary noop function args to mustCall()
1a539f5 
RefsL nodejs#45027
@aduh95 aduh95 mentioned this pull request Oct 18, 2022
Merged
aduh95
aduh95 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened #45047 to add the lint rule and fix the remaining occurences.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 18, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2022
@nodejs-github-bot nodejs-github-bot merged commit 6059cbe into nodejs:main Oct 18, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 6059cbe

aduh95 added a commit to aduh95/node that referenced this pull request Oct 18, 2022
@aduh95
test: remove unnecessary noop function args to mustCall()
0201008 
RefsL nodejs#45027
@Trott Trott deleted the noop branch October 18, 2022 12:36
nodejs-github-bot pushed a commit that referenced this pull request Oct 20, 2022
@aduh95
test: remove unnecessary noop function args to mustCall()
2c1b9f5 
RefsL #45027

PR-URL: #45047
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@Trott @RafaelGSS
test: remove unnecessary noop function args to mustCall()
a6a3439 
PR-URL: #45027
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@aduh95 @RafaelGSS
test: remove unnecessary noop function args to mustCall()
ec28e9b 
RefsL #45027

PR-URL: #45047
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@Trott @RafaelGSS
test: remove unnecessary noop function args to mustCall()
dbc696d 
PR-URL: #45027
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@aduh95 @RafaelGSS
test: remove unnecessary noop function args to mustCall()
f0480d6 
RefsL #45027

PR-URL: #45047
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
test: remove unnecessary noop function args to mustCall()
f2a0a3c 
PR-URL: #45027
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@aduh95 @danielleadams
test: remove unnecessary noop function args to mustCall()
c2371d5 
RefsL #45027

PR-URL: #45047
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
test: remove unnecessary noop function args to mustCall()
2859045 
PR-URL: #45027
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@aduh95 @danielleadams
test: remove unnecessary noop function args to mustCall()
53f0afe 
RefsL #45027

PR-URL: #45047
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@Trott @danielleadams
test: remove unnecessary noop function args to mustCall()
e5928ab 
PR-URL: #45027
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@aduh95 @danielleadams
test: remove unnecessary noop function args to mustCall()
b3c4265 
RefsL #45027

PR-URL: #45047
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @jasnell @lpinca @anonrig @cjihrig @aduh95