Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report,doc: define report version semantics #45050

Merged
merged 1 commit into from
Oct 21, 2022
Merged

report,doc: define report version semantics #45050

merged 1 commit into from
Oct 21, 2022

Conversation

gireeshpunathil
Copy link
Member

Diagnostics report has a version number representing its format, yet its rule is not defined. This doc change specifies the rule.

Refs: nodejs/diagnostics#349
Refs: #28121 (comment)

/cc @nodejs/diagnostics

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. report Issues and PRs related to process.report. labels Oct 18, 2022
cjihrig
cjihrig reviewed Oct 18, 2022
View reviewed changes
doc/api/report.md Outdated Show resolved Hide resolved
mhdawson
mhdawson approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gireeshpunathil
report,doc: define report version semantics
790a8b2 
Diagnostics report has a version number representing its format,
yet its rule is not defined. This doc change specifies the rule.

Refs: nodejs/diagnostics#349
Refs: nodejs#28121 (comment)
@gireeshpunathil gireeshpunathil added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 21, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 21, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/45050
FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close
    at consumeBody (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Response.text (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18)
    at async Request.json (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/lib/request.js:51:18)
    at async Request.query (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/lib/request.js:109:20)
    at async Request.queryAll (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/lib/request.js:136:20)
    at async Request.gql (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/lib/request.js:66:22)
    at async PRData.getComments (file:///opt/hostedtoolcache/node/16.17.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21)
    at async Promise.all (index 2)
    at async Promise.all (index 1) {
  type: 'system',
  errno: 'ERR_STREAM_PREMATURE_CLOSE',
  code: 'ERR_STREAM_PREMATURE_CLOSE',
  erroredSysCall: undefined
}
https://github.com/nodejs/node/actions/runs/3295384782

@gireeshpunathil
Copy link
Member Author

commit queue failed with this error:

FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close

not sure what this means. any idea?

@legendecas legendecas added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 21, 2022
@legendecas
Copy link
Member

I assume it is a network issue. Re-applying the commit queue.

@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 21, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 21, 2022 •
edited by legendecas
Loading

Commits were pushed since the last review.

Commit Queue failed
- Loading data for nodejs/node/pull/45050
✔  Done loading data for nodejs/node/pull/45050
----------------------------------- PR info ------------------------------------
Title      report,doc: define report version semantics (#45050)
Author     Gireesh Punathil  (@gireeshpunathil)
Branch     gireeshpunathil:report-version -> nodejs:main
Labels     doc, author ready, report
Commits    1
 - report,doc: define report version semantics
Committers 1
 - Gireesh Punathil 
PR-URL: https://github.com/nodejs/node/pull/45050
Refs: https://github.com/nodejs/diagnostics/issues/349
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Michael Dawson 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45050
Refs: https://github.com/nodejs/diagnostics/issues/349
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Michael Dawson 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - report,doc: define report version semantics
   ℹ  This PR was created on Tue, 18 Oct 2022 07:35:40 GMT
   ✔  Approvals: 6
   ✔  - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/45050#pullrequestreview-1145656434
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45050#pullrequestreview-1145697102
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45050#pullrequestreview-1146224600
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45050#pullrequestreview-1148302093
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/45050#pullrequestreview-1148701611
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/45050#pullrequestreview-1150061838
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3296201433

@legendecas legendecas added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2022
@nodejs-github-bot nodejs-github-bot merged commit c127e4e into nodejs:main Oct 21, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in c127e4e

@gireeshpunathil gireeshpunathil mentioned this pull request Oct 21, 2022
Closed
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@gireeshpunathil @RafaelGSS
report,doc: define report version semantics
d03619d 
Diagnostics report has a version number representing its format,
yet its rule is not defined. This doc change specifies the rule.

Refs: nodejs/diagnostics#349
Refs: #28121 (comment)
PR-URL: #45050
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@gireeshpunathil @RafaelGSS
report,doc: define report version semantics
66e1dc4 
Diagnostics report has a version number representing its format,
yet its rule is not defined. This doc change specifies the rule.

Refs: nodejs/diagnostics#349
Refs: #28121 (comment)
PR-URL: #45050
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@gireeshpunathil @danielleadams
report,doc: define report version semantics
6e5d411 
Diagnostics report has a version number representing its format,
yet its rule is not defined. This doc change specifies the rule.

Refs: nodejs/diagnostics#349
Refs: #28121 (comment)
PR-URL: #45050
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@gireeshpunathil @danielleadams
report,doc: define report version semantics
d9c06d1 
Diagnostics report has a version number representing its format,
yet its rule is not defined. This doc change specifies the rule.

Refs: nodejs/diagnostics#349
Refs: #28121 (comment)
PR-URL: #45050
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@gireeshpunathil @danielleadams
report,doc: define report version semantics
49da5cd 
Diagnostics report has a version number representing its format,
yet its rule is not defined. This doc change specifies the rule.

Refs: nodejs/diagnostics#349
Refs: #28121 (comment)
PR-URL: #45050
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@mhdawson mhdawson mhdawson approved these changes

@legendecas legendecas legendecas approved these changes

@richardlau richardlau richardlau approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gireeshpunathil @nodejs-github-bot @legendecas @jasnell @cjihrig @richardlau @mhdawson @RafaelGSS