Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update mark release line lts on release guide #45101

Merged
merged 5 commits into from
Oct 24, 2022
Merged

doc: update mark release line lts on release guide #45101

merged 5 commits into from
Oct 24, 2022

Conversation

ruyadorno
Copy link
Member

@ruyadorno ruyadorno commented Oct 20, 2022 •
edited
Loading

Updates the Release Guide to point to using node-core-utils for creating the commit that marks a release line as LTS.

cc @nodejs/releasers

@ruyadorno
doc: update mark release line lts on release guide
e6d1cdf 
Updates the Release Guide to point to using `node-core-utils` for
creating the commit that marks a release line as LTS.

Signed-off-by: Ruy Adorno <ruyadorno@google.com>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 20, 2022 •
edited by ruyadorno
Loading

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 20, 2022
mhdawson
mhdawson approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RafaelGSS
RafaelGSS reviewed Oct 21, 2022
View reviewed changes
doc/contributing/releases.md Outdated Show resolved Hide resolved
doc/contributing/releases.md Outdated Show resolved Hide resolved
ruyadorno and others added 2 commits October 21, 2022 11:16
@ruyadorno @RafaelGSS
Update doc/contributing/releases.md
c8653ea 
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
@ruyadorno @RafaelGSS
Update doc/contributing/releases.md
7c0a5cb 
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 21, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@ruyadorno ruyadorno added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 21, 2022
aduh95
aduh95 approved these changes Oct 22, 2022
View reviewed changes
doc/contributing/releases.md Show resolved Hide resolved
@ruyadorno @aduh95
Update doc/contributing/releases.md
520e533 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Oct 24, 2022
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 24, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2022
@nodejs-github-bot nodejs-github-bot merged commit 1930fcd into nodejs:main Oct 24, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 1930fcd

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@ruyadorno @RafaelGSS
doc: update mark release line lts on release guide
423307c 
Updates the Release Guide to point to using `node-core-utils` for
creating the commit that marks a release line as LTS.

Signed-off-by: Ruy Adorno <ruyadorno@google.com>
PR-URL: #45101
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@ruyadorno @RafaelGSS
doc: update mark release line lts on release guide
85cb4d7 
Updates the Release Guide to point to using `node-core-utils` for
creating the commit that marks a release line as LTS.

Signed-off-by: Ruy Adorno <ruyadorno@google.com>
PR-URL: #45101
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@ruyadorno @danielleadams
doc: update mark release line lts on release guide
896e7e9 
Updates the Release Guide to point to using `node-core-utils` for
creating the commit that marks a release line as LTS.

Signed-off-by: Ruy Adorno <ruyadorno@google.com>
PR-URL: #45101
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@ruyadorno @danielleadams
doc: update mark release line lts on release guide
f390de9 
Updates the Release Guide to point to using `node-core-utils` for
creating the commit that marks a release line as LTS.

Signed-off-by: Ruy Adorno <ruyadorno@google.com>
PR-URL: #45101
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@ruyadorno @danielleadams
doc: update mark release line lts on release guide
17380a1 
Updates the Release Guide to point to using `node-core-utils` for
creating the commit that marks a release line as LTS.

Signed-off-by: Ruy Adorno <ruyadorno@google.com>
PR-URL: #45101
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@aduh95 aduh95 aduh95 approved these changes

@mhdawson mhdawson mhdawson approved these changes

@legendecas legendecas legendecas approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.