Fix Intel VTune profiling support #45248
Conversation
|
Review requested:
|
nodejs-github-bot
added
build
|
There seems to be unrelated (eslint-related) commits added here? Also, with vtune support being removed back in 2019 due to bitrot, is there any kind of guarantee we won't see a repeat of this? |
|
You also need to upstream v8 patches in v8 repo |
No need for now. The ittapi code has been in V8 repo. At present Node.js node-core-util lack of the auto sync-up support for V8 ittapi componenent and this was addressed by PR nodejs/node-core-utils#552. The reviewing decision of PR 552 is that it will be landed after vtune patch landed. So for now, the solution is I commit the V8 depedency ittapi to Node.js for the first time, and then land the node-core-util PR. In future ittapi could be sync up automatically. |
The root cause of 2019 bitrot is that we had code changes in V8 repo but not synced to Node.js repo. To avoid such issue there are options like
Please advice more options. Thanks! |
|
Changes to config/build files LGTM. /cc @nodejs/cpp-reviewers |
|
There are 2 lint related patch submitted. Is there a way to remove them without resubmitting PR again? |
You can try squashing the commits and force-push the same branch to GitHub. |
git rebase -i HEAD~3
# Remove the unreleated commits
git push --force-with-lease |
Node's CI matrix is already unwieldy and realistically no one cares (reports bugs) about vtune except Intel personnel. If Intel wants to be more proactive w.r.t. fixing issues, that's of course welcome, just send pull requests. |
Done. Thank you! |
Sure. Will submit a new PR to enable the checks in Windows build and Linux buid CI checks. |
|
All review comments are resolved. Please kindly have a review and submit. |
|
@nodejs/build |
|
@lucshi seems like something went wrong while pushing something new to the branch :-) |
github-actions
bot
removed
the
request-ci
|
Can this PR be merged? |
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d783a1c |
Add ittapi to the list of V8 dependencies, which is used by VTune JIT profiling. Refs: nodejs/node#45248
PR-URL: nodejs#45248 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #45248 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #45248 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #45248 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #45248 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #45248 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #45248 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Add ittapi to the list of V8 dependencies, which is used by VTune JIT profiling. Refs: nodejs/node#45248
We received upcoming requests to fix the broken building of Intel
Vtune on Node.js to profile JS and JITted code.
This change fix the Intel Vtune profiling support for JITted
JavaScript on IA32 / X64 / X32 platform. The advantage of this profiling
is that the user / developer of NodeJS application can get the detailed
profiling information for every line of the JavaScript source code and
JITted code.
This feature is a compile-time option. For windows platform, the user
needs to pass the following parameter to vcbuild.bat: "enable-vtune"
For other OS, the user needs to pass the following parameter to
./configure command: "--enable-vtune-profiling"
This fix was originally address in PR and author is @fanchenkong1
fanchen.kong@intel.com in
#39374 last year. The PR has been
broken in current Node.js repo and I fixed the broken, fully tested and
submit this new PR on behalf of @fanchenkong1.