-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: fix request-ci-failed
comment
#45291
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
aduh95:request-ci-failed-comment-epic-fail
Nov 3, 2022
Merged
tools: fix request-ci-failed
comment
#45291
nodejs-github-bot
merged 1 commit into
nodejs:main
from
aduh95:request-ci-failed-comment-epic-fail
Nov 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
richardlau
approved these changes
Nov 2, 2022
aduh95
added
fast-track
PRs that do not need to wait for 48 hours to land.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Nov 2, 2022
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Trott
approved these changes
Nov 3, 2022
gengjiawen
approved these changes
Nov 3, 2022
gengjiawen
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 3, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 3, 2022
Landed in a3874dd |
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 9, 2022
PR-URL: nodejs#45291 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #45291 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45291 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45291 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45291 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fast-track
PRs that do not need to wait for 48 hours to land.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #45243 (comment)