Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools,test: enable eslint no-unused-vars #4536

Closed
wants to merge 2 commits into from
Closed

tools,test: enable eslint no-unused-vars #4536

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 5, 2016

No description provided.

@Trott Trott added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Jan 5, 2016
@Trott
Copy link
Member Author

Trott commented Jan 5, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/1146/

@rvagg
Copy link
Member

rvagg commented Jan 5, 2016

so much copypasta in some of those test files

lgtm pending CI

@targos
Copy link
Member

targos commented Jan 5, 2016

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Jan 5, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Jan 5, 2016

CI failures look unrelated. LGTM

Trott added a commit that referenced this pull request Jan 5, 2016
@Trott @jasnell
test: remove unused vars
bc39d6a 
Remove unused vars in tests

PR-URL: #4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott added a commit that referenced this pull request Jan 5, 2016
@Trott @jasnell
tools: implement no-unused-vars for eslint
775cfdc 
PR-URL: #4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 5, 2016

Landed in bc39d6a and 775cfdc

@jasnell jasnell closed this Jan 5, 2016
@silverwind silverwind mentioned this pull request Jan 6, 2016
Closed
@Fishrock123 Fishrock123 mentioned this pull request Jan 6, 2016
Merged
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
@Trott @Fishrock123
test: remove unused vars
4b14f1c 
Remove unused vars in tests

PR-URL: nodejs#4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Conflicts:
	test/parallel/test-timers-throw-when-cb-not-function.js
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
@Trott @Fishrock123
tools: implement no-unused-vars for eslint
386030b 
PR-URL: nodejs#4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins
Copy link
Contributor

@Trott would you be able to manually backport this commit to v4.x?

MylesBorins pushed a commit that referenced this pull request Jan 13, 2016
@Trott
tools: implement no-unused-vars for eslint
31b6580 
PR-URL: #4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 14, 2016
Closed
@MylesBorins MylesBorins mentioned this pull request Jan 14, 2016
Merged
@Trott
Copy link
Member Author

Trott commented Jan 14, 2016

@thealphanerd Looks like this is now part of #4688 so I won't backport it myself. If that's a misunderstanding, let me know.

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Jan 14, 2016
@Trott
test: remove unused vars
7894f19 
Remove unused vars in tests

PR-URL: nodejs#4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Jan 14, 2016
@Trott
tools: implement no-unused-vars for eslint
ef5e9ef 
PR-URL: nodejs#4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@Trott
test: remove unused vars
2f4538d 
Remove unused vars in tests

PR-URL: #4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@Trott
tools: implement no-unused-vars for eslint
69fef19 
PR-URL: #4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
test: remove unused vars
30c3700 
Remove unused vars in tests

PR-URL: nodejs#4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
tools: implement no-unused-vars for eslint
9c2492d 
PR-URL: nodejs#4536
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott Trott deleted the eslint-no-unused-vars branch January 13, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @rvagg @targos @cjihrig @jasnell @MylesBorins