Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Fix email for Ashley #45364

Merged
merged 2 commits into from
Nov 8, 2022
Merged

doc: Fix email for Ashley #45364

merged 2 commits into from
Nov 8, 2022

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Nov 7, 2022

Signed-off-by: Michael Dawson mdawson@devrus.com

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 7, 2022
@mhdawson
Copy link
Member Author

mhdawson commented Nov 7, 2022

@AshCripps FYI

AshCripps
AshCripps approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@AshCripps AshCripps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks for this I didn't realise I had left this in.

@Trott
Copy link
Member

Trott commented Nov 8, 2022

We'll want to add a .mailmap entry and update AUTHORS as well.

mhdawson and others added 2 commits November 7, 2022 18:47
@mhdawson @Trott
doc: fix email for Ashley
f28e8f5 
Signed-off-by: Michael Dawson <mdawson@devrus.com>
@Trott
fixup! doc: fix email for Ashley
1bd5c04
@Trott
Copy link
Member

Trott commented Nov 8, 2022

We'll want to add a .mailmap entry and update AUTHORS as well.

I did this and pushed the results in a fixup commit.

@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Fast-track has been requested by @Trott. Please 👍 to approve.

@mhcrocky

This comment was marked as spam.

Sign in to view
@Trott

This comment was marked as resolved.

Sign in to view
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2022
@nodejs-github-bot nodejs-github-bot merged commit 59938e3 into nodejs:main Nov 8, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 59938e3

lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022
@mhdawson
doc: fix email for Ashley
b0315d3 
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: nodejs#45364
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@mhdawson @RafaelGSS
doc: fix email for Ashley
ba45373 
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #45364
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 10, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@mhdawson @danielleadams
doc: fix email for Ashley
a05949e 
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #45364
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@mhdawson @danielleadams
doc: fix email for Ashley
bef5d3d 
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #45364
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@mhdawson @danielleadams
doc: fix email for Ashley
846b1ae 
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #45364
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@mhdawson @danielleadams
doc: fix email for Ashley
31c81b2 
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #45364
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshCripps AshCripps AshCripps approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@tniessen tniessen tniessen approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mhdawson @Trott @mhcrocky @nodejs-github-bot @tniessen @BethGriggs @AshCripps