doc: bring releases.md up to date #4540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
meta
| ``` | ||
|
|
||
| ### 4. Update _src/node_version.h_ | ||
| The release type should be either Stable, LTS, or Maintenance, depending on the type of release being produced. |
There was a problem hiding this comment.
Should likely note that only the LTS WG can cut LTS releases and that there is a slightly modified process that uses the various -staging branches
There was a problem hiding this comment.
@jasnell since the audience for this document is the release and LTS team members, and I'm not totally up to speed on the LTS release process, would you be OK with adding the LTS specific info in a subsequent PR?
|
Only performed a cursory look through but generally LGTM |
|
Thanks for the review. Landed in f1653cc. |
Merged
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Refs: nodejs#3254 PR-URL: nodejs#4540 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit brings the release procedure documentation up to date. I tried to consolidate the material in the existing
releases.mdwith #3254 and #4384 (comment).Refs: #3254
R= @nodejs/release