Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add missing step in update-base64.sh script #45509

Closed
wants to merge 2 commits into from
Closed

tools: add missing step in update-base64.sh script #45509

wants to merge 2 commits into from

Conversation

facutuesca
Copy link
Contributor

This PR adds an extra step to the update-base64.sh script, which adds an empty config.h header after updating base64.

The reason for this is that config.h needs to exist in order to compile base64. In upstream, this header is used to define which processor extensions should be supported (see here). Since in Node's build this is handled by the base64.gyp file, we leave the config.h file empty.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 18, 2022
@facutuesca facutuesca mentioned this pull request Nov 18, 2022
Closed
@facutuesca
Copy link
Contributor Author

cc @targos @jasnell

@targos
Copy link
Member

targos commented Nov 18, 2022

Could you use the script to make the actual update in a second commit? This will validate that it works next time.

@facutuesca
Copy link
Contributor Author

facutuesca commented Nov 18, 2022 •
edited
Loading

Could you use the script to make the actual update in a second commit? This will validate that it works next time.

@targos What do you mean? AFAICT when this is merged, the next time the script runs a new PR will be created with the changes here minus the deletion of config.h, and CI will validate that everything compiles/runs correctly

@targos
Copy link
Member

targos commented Nov 18, 2022

You're right, but I don't want to wait for the automated PR to validate that everything works correctly. It can be easily done here IMO.

@facutuesca
Copy link
Contributor Author

You're right, but I don't want to wait for the automated PR to validate that everything works correctly. It can be easily done here IMO.

@targos Done!

@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 18, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48012/

@targos targos mentioned this pull request Nov 20, 2022
Closed
@targos targos added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Nov 20, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 20, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 8822f40...4bee69a

nodejs-github-bot pushed a commit that referenced this pull request Nov 20, 2022
@facutuesca @nodejs-github-bot
tools: add missing step in update-base64.sh script
c0bbcd4 
PR-URL: #45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit that referenced this pull request Nov 20, 2022
@facutuesca @nodejs-github-bot
deps: update base64 to 0.5.0
4bee69a 
PR-URL: #45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@facutuesca @ruyadorno
tools: add missing step in update-base64.sh script
d4f30f0 
PR-URL: #45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@facutuesca @ruyadorno
deps: update base64 to 0.5.0
43e002e 
PR-URL: #45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@facutuesca @marco-ippolito
tools: add missing step in update-base64.sh script
8c374da 
PR-URL: nodejs#45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@facutuesca @marco-ippolito
deps: update base64 to 0.5.0
b0f822e 
PR-URL: nodejs#45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@facutuesca @danielleadams
tools: add missing step in update-base64.sh script
a10f0e5 
PR-URL: #45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@facutuesca @danielleadams
deps: update base64 to 0.5.0
62447e7 
PR-URL: #45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@facutuesca @danielleadams
tools: add missing step in update-base64.sh script
c97df11 
PR-URL: #45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@facutuesca @danielleadams
deps: update base64 to 0.5.0
f200e35 
PR-URL: #45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@facutuesca @danielleadams
tools: add missing step in update-base64.sh script
360c7be 
PR-URL: #45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@facutuesca @danielleadams
deps: update base64 to 0.5.0
02eabaf 
PR-URL: #45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@facutuesca @danielleadams
tools: add missing step in update-base64.sh script
d215e3e 
PR-URL: #45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@facutuesca @danielleadams
deps: update base64 to 0.5.0
e7d4a44 
PR-URL: #45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@facutuesca @danielleadams
tools: add missing step in update-base64.sh script
6b08409 
PR-URL: #45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@facutuesca @danielleadams
deps: update base64 to 0.5.0
67489ee 
PR-URL: #45509
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@facutuesca @targos @nodejs-github-bot @lpinca @anonrig @richardlau