src,lib: group properties used as constants from `util` binding #45539

daeyeon · 2022-11-20T07:58:22Z

The ways to create properties used as constants are scattered in util internal binding.
This PR gets them created in one code block and creates an object holding all of them.

Similar object patterns can be found in other bindings.

node/lib/dgram.js

Lines 71 to 75 in db88483

    
           const { 
        
             constants: { UV_UDP_IPV6ONLY }, 
        
             UDP, 
        
             SendWrap 
        
           } = internalBinding('udp_wrap');

node/lib/internal/perf/nodetiming.js

Lines 21 to 31 in db88483

    
           const { 
        
             constants: { 
        
               NODE_PERFORMANCE_MILESTONE_NODE_START, 
        
               NODE_PERFORMANCE_MILESTONE_V8_START, 
        
               NODE_PERFORMANCE_MILESTONE_LOOP_START, 
        
               NODE_PERFORMANCE_MILESTONE_LOOP_EXIT, 
        
               NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE, 
        
               NODE_PERFORMANCE_MILESTONE_ENVIRONMENT 
        
             }, 
        
             loopIdleTime, 
        
           } = internalBinding('performance');

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

Properties used as constants in `util` internal binding are scattered. This suggests using an object holding all of them for better maintenance. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

nodejs-github-bot · 2022-11-20T07:58:25Z

Review requested:

@nodejs/startup
@nodejs/cpp-reviewers

src/node_util.cc

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

… binding Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

nodejs-github-bot · 2022-11-23T14:56:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48125/

nodejs-github-bot · 2022-11-24T02:09:31Z

Landed in be9cd3e

ruyadorno · 2022-11-24T16:48:56Z

@daeyeon be9cd3e does not land cleanly on the release branch v19.x-staging. It will need backporting.

Properties used as constants in `util` internal binding are scattered. This suggests using an object holding all of them for better maintenance. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: nodejs#45539 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Properties used as constants in `util` internal binding are scattered. This suggests using an object holding all of them for better maintenance. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: nodejs#45539 Backport-PR-URL: nodejs#45674 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Properties used as constants in `util` internal binding are scattered. This suggests using an object holding all of them for better maintenance. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #45539 Backport-PR-URL: #45674 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

src,lib: group properties used as constants from util binding

8b95729

Properties used as constants in `util` internal binding are scattered. This suggests using an object holding all of them for better maintenance. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 20, 2022

daeyeon added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 20, 2022

RaisinTen approved these changes Nov 21, 2022

View reviewed changes

daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2022

This comment was marked as outdated.

Sign in to view

legendecas approved these changes Nov 21, 2022

View reviewed changes

JungMinu approved these changes Nov 22, 2022

View reviewed changes

joyeecheung reviewed Nov 22, 2022

View reviewed changes

src/node_util.cc Outdated Show resolved Hide resolved

fixup! src,lib: group properties used as constants from util binding

21e2ae8

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2022

This comment was marked as outdated.

Sign in to view

fixup! fixup! src,lib: group properties used as constants from util…

397662e

… binding Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>

daeyeon force-pushed the main.util-constants-221120.Sun.a9c7 branch from e1cc165 to 397662e Compare November 23, 2022 06:40

joyeecheung approved these changes Nov 23, 2022

View reviewed changes

daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2022

This comment was marked as outdated.

Sign in to view

github-actions bot mentioned this pull request Nov 24, 2022

CI Reliability 2022-11-24 nodejs/reliability#438

Open

16 tasks

daeyeon added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2022

nodejs-github-bot merged commit be9cd3e into nodejs:main Nov 24, 2022

daeyeon deleted the main.util-constants-221120.Sun.a9c7 branch November 24, 2022 02:56

ruyadorno added the backport-requested-v19.x label Nov 24, 2022

This was referenced Nov 25, 2022

CI Reliability 2022-11-25 nodejs/reliability#439

Open

CI Reliability 2022-11-26 nodejs/reliability#440

Open

CI Reliability 2022-11-27 nodejs/reliability#441

Open

CI Reliability 2022-11-28 nodejs/reliability#442

Open

daeyeon mentioned this pull request Nov 29, 2022

[v19.x backport] src,lib: group properties used as constants from util binding #45674

Closed

daeyeon added backport-open-v19.x and removed backport-requested-v19.x labels Nov 29, 2022

targos added backported-to-v19.x and removed backport-open-v19.x labels Dec 12, 2022

targos mentioned this pull request Dec 12, 2022

v19.3.0 release proposal #45831

Merged

danielleadams mentioned this pull request Dec 30, 2022

v18.13.0 release proposal #46025

Merged

harrisi mentioned this pull request Feb 19, 2023

.load infinite loop in REPL #46731

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src,lib: group properties used as constants from `util` binding #45539

src,lib: group properties used as constants from `util` binding #45539

daeyeon commented Nov 20, 2022 •

edited

Loading

nodejs-github-bot commented Nov 20, 2022 •

edited by daeyeon

Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Nov 23, 2022

nodejs-github-bot commented Nov 24, 2022

ruyadorno commented Nov 24, 2022

	const {
	constants: { UV_UDP_IPV6ONLY },
	UDP,
	SendWrap
	} = internalBinding('udp_wrap');

	const {
	constants: {
	NODE_PERFORMANCE_MILESTONE_NODE_START,
	NODE_PERFORMANCE_MILESTONE_V8_START,
	NODE_PERFORMANCE_MILESTONE_LOOP_START,
	NODE_PERFORMANCE_MILESTONE_LOOP_EXIT,
	NODE_PERFORMANCE_MILESTONE_BOOTSTRAP_COMPLETE,
	NODE_PERFORMANCE_MILESTONE_ENVIRONMENT
	},
	loopIdleTime,
	} = internalBinding('performance');

src,lib: group properties used as constants from util binding #45539

src,lib: group properties used as constants from util binding #45539

Conversation

daeyeon commented Nov 20, 2022 • edited Loading

nodejs-github-bot commented Nov 20, 2022 • edited by daeyeon Loading

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Nov 23, 2022

nodejs-github-bot commented Nov 24, 2022

ruyadorno commented Nov 24, 2022

src,lib: group properties used as constants from `util` binding #45539

src,lib: group properties used as constants from `util` binding #45539

daeyeon commented Nov 20, 2022 •

edited

Loading

nodejs-github-bot commented Nov 20, 2022 •

edited by daeyeon

Loading