Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x] lib: drop fetch experimental warning #45628

Closed
wants to merge 1 commit into from
Closed

[v18.x] lib: drop fetch experimental warning #45628

wants to merge 1 commit into from

Conversation

Richienb
Copy link
Contributor

@Richienb Richienb commented Nov 26, 2022 •
edited
Loading

Backports #45287 by cherry-picking the commit.

@mcollina @Richienb
lib: drop fetch experimental warning
c71009d 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: nodejs#45287
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Nov 26, 2022
styfle
styfle approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I also think the docs need to be updated since those still stay experimental here: https://nodejs.org/api/globals.html#fetch

@Richienb
Copy link
Contributor Author

I also think the docs need to be updated since those still stay experimental here: nodejs.org/api/globals.html#fetch

I believe this also applies to the verison this pr is based on too. I believe documentation updates are an upstream problem and should be done there first in the main branch.

@styfle
Copy link
Member

styfle commented Nov 30, 2022

Sounds good! I created a PR: #45684

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48753/

@danielleadams
Copy link
Contributor

@Richienb this is already landing in v18.x in v18.13.0 (#46025). Can this be closed?

@Richienb Richienb closed this Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Richienb @styfle @nodejs-github-bot @danielleadams @mcollina