Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: run t.after() if test body throws #45870

Merged
merged 1 commit into from
Dec 17, 2022
Merged

test_runner: run t.after() if test body throws #45870

merged 1 commit into from
Dec 17, 2022
+35 −4

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 15, 2022

This commit fixes a bug where t.after() was not called if the test body threw an exception.

@cjihrig
test_runner: run t.after() if test body throws
a2de82c 
This commit fixes a bug where t.after() was not called if the
test body threw an exception.
@cjihrig cjihrig added the test_runner Issues and PRs related to the test runner subsystem. label Dec 15, 2022
@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. labels Dec 15, 2022
MoLow
MoLow approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@cjihrig cjihrig requested a review from mcollina December 15, 2022 14:18
mcollina
mcollina approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 15, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48504/

@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 15, 2022
@cjihrig cjihrig removed the needs-ci PRs that need a full CI run. label Dec 15, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48517/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48518/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 16, 2022 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/48525/ 💛

@github-actions github-actions bot mentioned this pull request Dec 17, 2022
Open
13 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 17, 2022
@nodejs-github-bot nodejs-github-bot merged commit 385d595 into nodejs:main Dec 17, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 385d595

@cjihrig cjihrig deleted the after-fix branch December 17, 2022 14:49
This was referenced Dec 18, 2022
Open
Open
Open
targos pushed a commit that referenced this pull request Jan 1, 2023
@cjihrig @targos
test_runner: run t.after() if test body throws
c5004d4 
This commit fixes a bug where t.after() was not called if the
test body threw an exception.

PR-URL: #45870
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
@cjihrig @MoLow
test_runner: run t.after() if test body throws
5dc4643 
This commit fixes a bug where t.after() was not called if the
test body threw an exception.

PR-URL: nodejs#45870
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jan 26, 2023
@cjihrig @MoLow
test_runner: run t.after() if test body throws
06ff291 
This commit fixes a bug where t.after() was not called if the
test body threw an exception.

PR-URL: nodejs#45870
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MoLow MoLow mentioned this pull request Jan 26, 2023
Closed
@MoLow MoLow added the backport-open-v18.x Indicate that the PR has an open backport. label Jan 26, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@cjihrig @juanarbol
test_runner: run t.after() if test body throws
cade2fc 
This commit fixes a bug where t.after() was not called if the
test body threw an exception.

PR-URL: #45870
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MoLow MoLow removed the backport-open-v18.x Indicate that the PR has an open backport. label Jan 26, 2023
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@cjihrig @MoLow
fix: run t.after() if test body throws
c80e426 
This commit fixes a bug where t.after() was not called if the
test body threw an exception.

PR-URL: nodejs/node#45870
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
(cherry picked from commit 385d595a4f1d887f6d4221e6071571132498d57c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjihrig @nodejs-github-bot @mcollina @MoLow