Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update example of using await in REPL #45939

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

doc: update example of using await in REPL #45939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f4446c
doc: remove limitation of using `await` in REPL
deokjinkim Dec 21, 2022
2de633c
doc: update example of using `await` in REPL
deokjinkim Dec 23, 2022
6a7ae88
add test case according to change of document in REPL
deokjinkim Jan 3, 2023
d6b4483
enhance test case
deokjinkim Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions doc/api/repl.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,7 @@ undefined
```

One known limitation of using the `await` keyword in the REPL is that
it will invalidate the lexical scoping of the `const` and `let`
keywords.
it will invalidate the lexical scoping of the `const` keywords.

For example:

Expand All @@ -245,9 +244,7 @@ For example:
undefined
> m
123
> const m = await Promise.resolve(234)
undefined
> m
> m = await Promise.resolve(234)
234
```

Expand Down
4 changes: 4 additions & 0 deletions test/parallel/test-repl-top-level-await.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,10 @@ async function ordinaryTests() {
'3',
'undefined',
]],
['const k = await Promise.resolve(123)'],
['k', '123'],
['k = await Promise.resolve(234)', '234'],
deokjinkim marked this conversation as resolved.
Show resolved Hide resolved
['k', '234'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the drive the point home:

Suggested change
['k', '234'],
['k', '234'],
['const k = await Promise.resolve(345)'],
['k', '345'],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 180 causes error like 'Uncaught SyntaxError: Identifier 'k' has already been declared'.
When I tested,

// This is allowed
const k = await Promise.resolve(123)
k = await Promise.resolve(234)

// This is not allowed
const k = await Promise.resolve(123)
const k = await Promise.resolve(234)

// Regression test for https://github.com/nodejs/node/issues/43777.
['await Promise.resolve(123), Promise.resolve(456)', 'Promise {', { line: 0 }],
['await Promise.resolve(123), await Promise.resolve(456)', '456'],
Expand Down