-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src,lib: the handle keeps loop alive in cluster rr mode #46161
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
theanarkh:keep_loop_alive_in_cluster_shared_mode
Jan 16, 2023
Merged
src,lib: the handle keeps loop alive in cluster rr mode #46161
nodejs-github-bot
merged 1 commit into
nodejs:main
from
theanarkh:keep_loop_alive_in_cluster_shared_mode
Jan 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
cluster
Issues and PRs related to the cluster subsystem.
needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
labels
Jan 10, 2023
bnoordhuis
reviewed
Jan 10, 2023
theanarkh
force-pushed
the
keep_loop_alive_in_cluster_shared_mode
branch
2 times, most recently
from
January 11, 2023 16:09
4eeac79
to
b93fc9c
Compare
bnoordhuis
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (improves on the existing state of things) but see comment.
theanarkh
force-pushed
the
keep_loop_alive_in_cluster_shared_mode
branch
from
January 12, 2023 00:29
b93fc9c
to
934837c
Compare
JungMinu
approved these changes
Jan 12, 2023
theanarkh
force-pushed
the
keep_loop_alive_in_cluster_shared_mode
branch
from
January 12, 2023 16:20
934837c
to
c1486d4
Compare
theanarkh
force-pushed
the
keep_loop_alive_in_cluster_shared_mode
branch
from
January 12, 2023 16:24
c1486d4
to
415cbe7
Compare
bnoordhuis
approved these changes
Jan 12, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 13, 2023
theanarkh
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jan 13, 2023
jasnell
reviewed
Jan 13, 2023
This was referenced Jan 14, 2023
theanarkh
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 16, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 16, 2023
Landed in 7895484 |
17 tasks
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
PR-URL: nodejs#46161 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
18 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
PR-URL: #46161 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
PR-URL: #46161 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
PR-URL: #46161 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
cluster
Issues and PRs related to the cluster subsystem.
needs-ci
PRs that need a full CI run.
util
Issues and PRs related to the built-in util module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handle does not keep loop alive in cluster rr mode, the code is as follows.
So try to fix this issue.
make -j4 test
(UNIX), orvcbuild test
(Windows) passes