Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump googletest to 2023.01.13 #46198

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

gengjiawen
Copy link
Member

subtask of #46194.

Also fix some issue on cpp20.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jan 13, 2023
@gengjiawen gengjiawen added request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 13, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @gengjiawen. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2023
@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member

deps: bump googletest to 2023.01.13

If this is not a release, could you include the commit hash you bumped to in the commit message?

@gengjiawen
Copy link
Member Author

gengjiawen commented Jan 13, 2023

deps: bump googletest to 2023.01.13

If this is not a release, could you include the commit hash you bumped to in the commit message?

For the hash Sure. But googletest will not draft any new release. Hash looks the only way in the future.

GoogleTest now follows the Abseil Live at Head philosophy. We recommend updating to the latest commit in the main branch as often as possible.

commit hash: 356fc301251378e0f6fa6aa794d73714202887ac
@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@gengjiawen gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 15, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 15, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/46198
✔  Done loading data for nodejs/node/pull/46198
----------------------------------- PR info ------------------------------------
Title      deps: bump googletest to 2023.01.13 (#46198)
Author     Jiawen Geng  (@gengjiawen)
Branch     gengjiawen:feat/bump_gtest -> nodejs:main
Labels     fast-track, needs-ci, dependencies
Commits    1
 - deps: bump googletest to 2023.01.13
Committers 1
 - Jiawen Geng 
PR-URL: https://github.com/nodejs/node/pull/46198
Reviewed-By: Richard Lau 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46198
Reviewed-By: Richard Lau 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 13 Jan 2023 10:14:51 GMT
   ✔  Approvals: 4
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/46198#pullrequestreview-1247529039
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/46198#pullrequestreview-1247678664
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46198#pullrequestreview-1247778622
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46198#pullrequestreview-1248977483
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-01-14T00:22:53Z: https://ci.nodejs.org/job/node-test-pull-request/48978/
- Querying data for job/node-test-pull-request/48978/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3923324332

@targos targos added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 15, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 15, 2023
@nodejs-github-bot nodejs-github-bot merged commit d094f1b into nodejs:main Jan 15, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in d094f1b

@gengjiawen gengjiawen deleted the feat/bump_gtest branch January 15, 2023 12:47
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
commit hash: 356fc301251378e0f6fa6aa794d73714202887ac

PR-URL: nodejs#46198
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
commit hash: 356fc301251378e0f6fa6aa794d73714202887ac

PR-URL: #46198
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
commit hash: 356fc301251378e0f6fa6aa794d73714202887ac

PR-URL: #46198
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
commit hash: 356fc301251378e0f6fa6aa794d73714202887ac

PR-URL: #46198
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants