build: Add VARIATION variable to binary target #4631
Conversation
If the VARIATION variable is present, then make binary will produce archives named node-$(FULLVERSION)-$(PLATFORM)-$(ARCH)-$(VARIATION).
|
not a bad idea, I think, /cc @nodejs/build |
|
Sure, see no issue with it either. |
|
@mhdawson Does this look okay to you? Thanks! |
|
lgtm |
|
I can land it -- @rvagg LGTY? |
|
Sorry, just saw this, yeah LGTM!
|
|
lgtm pending https://ci.nodejs.org/job/node-test-pull-request/1338/ We also need to pay attention to the next nightly that comes out of this when landed to make sure it's working OK. |
|
arm fails seem unrelated. Merging. |
If the VARIATION variable is present, then make binary will produce archives named node-$(FULLVERSION)-$(PLATFORM)-$(ARCH)-$(VARIATION). PR-URL: #4631 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
|
Landed in bf12379. |
|
marking this one as do not land in v4.x. It would likely be ok to land but given the change to the filename it could potentially break tooling. If anyone feels lts is appropriate, however, lemme know :-) |
If the VARIATION variable is present, then make binary will produce archives named node-$(FULLVERSION)-$(PLATFORM)-$(ARCH)-$(VARIATION). PR-URL: #4631 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
If the VARIATION variable is present, then make binary will produce archives named node-$(FULLVERSION)-$(PLATFORM)-$(ARCH)-$(VARIATION). PR-URL: nodejs#4631 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
If the VARIATION variable is present, then "make binary" will produce archives named node-$(FULLVERSION)-$(PLATFORM)-$(ARCH)-$(VARIATION).
This capability is useful when building variations of Node.js for the same platform/architecture. For example, when building x64 Linux with FIPS compliant crypto provider, it is useful to have a "-fips" suffix to easily identify this functionality without having to examine the contents.
Contrast: node-v6.0.0-linux-x64.tar.gz vs node-v6.0.0-linux-x64-variation.tar.gz