Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x] deps: V8: cherry-pick c875e86df1d7 #46501

Closed
wants to merge 1 commit into from
Closed

[v18.x] deps: V8: cherry-pick c875e86df1d7 #46501

wants to merge 1 commit into from

Conversation

sepehrst
Copy link

@sepehrst sepehrst commented Feb 5, 2023

Original commit message:

[bigint] Convert BigInt property names to decimal

Hexadecimal/octal/binary BigInt property names should be converted
to decimal, i.e. the following object literals should all be equivalent:
var o = {0xF: 1}, p = {0xFn: 1}, q = {15: 1}, r = {15n: 1}.

Test case by yangwenming@bytedance.com, uploaded at
https://chromium-review.googlesource.com/c/v8/v8/+/3634937

Fixed: v8:10600
Change-Id: Ie1d8a16e95697cd31cbc0784843779c921ce91fa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642302
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80490}

Refs: v8/v8@c875e86
Refs: #43203 (comment)

@sepehrst
deps: V8: cherry-pick c875e86df1d7 (#2)
85c7432 
Original commit message:

    [bigint] Convert BigInt property names to decimal

    Hexadecimal/octal/binary BigInt property names should be converted
    to decimal, i.e. the following object literals should all be equivalent:
    var o = {0xF: 1}, p = {0xFn: 1}, q = {15: 1}, r = {15n: 1}.

    Test case by yangwenming@bytedance.com, uploaded at
    https://chromium-review.googlesource.com/c/v8/v8/+/3634937

    Fixed: v8:10600
    Change-Id: Ie1d8a16e95697cd31cbc0784843779c921ce91fa
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642302
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80490}

Refs: v8/v8@c875e86
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Feb 5, 2023
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49392/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5161/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5161/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5161/

@github-actions github-actions bot mentioned this pull request Feb 6, 2023
Open
19 tasks
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Open
18 tasks
@MylesBorins MylesBorins added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49714/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/5183/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5183/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5183/

This was referenced Feb 20, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49959/

@github-actions github-actions bot mentioned this pull request Feb 25, 2023
Open
28 tasks
@sepehrst

This comment was marked as resolved.

Sign in to view
This was referenced Feb 26, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50045/

juanarbol pushed a commit to juanarbol/node that referenced this pull request Mar 1, 2023
@sepehrst @juanarbol
deps: V8: cherry-pick c875e86df1d7 (nodejs#2)
795f9d8 
Original commit message:

    [bigint] Convert BigInt property names to decimal

    Hexadecimal/octal/binary BigInt property names should be converted
    to decimal, i.e. the following object literals should all be equivalent:
    var o = {0xF: 1}, p = {0xFn: 1}, q = {15: 1}, r = {15n: 1}.

    Test case by yangwenming@bytedance.com, uploaded at
    https://chromium-review.googlesource.com/c/v8/v8/+/3634937

    Fixed: v8:10600
    Change-Id: Ie1d8a16e95697cd31cbc0784843779c921ce91fa
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642302
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80490}

Refs: v8/v8@c875e86
PR-URL: nodejs#46501
Refs: v8/v8@c875e86
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@juanarbol
Copy link
Member

Landed in 795f9d8

@juanarbol juanarbol closed this Mar 1, 2023
@juanarbol juanarbol mentioned this pull request Mar 3, 2023
Merged
juanarbol pushed a commit that referenced this pull request Mar 5, 2023
@sepehrst @juanarbol
deps: V8: cherry-pick c875e86df1d7
3ea53c5 
Original commit message:

    [bigint] Convert BigInt property names to decimal

    Hexadecimal/octal/binary BigInt property names should be converted
    to decimal, i.e. the following object literals should all be equivalent:
    var o = {0xF: 1}, p = {0xFn: 1}, q = {15: 1}, r = {15n: 1}.

    Test case by yangwenming@bytedance.com, uploaded at
    https://chromium-review.googlesource.com/c/v8/v8/+/3634937

    Fixed: v8:10600
    Change-Id: Ie1d8a16e95697cd31cbc0784843779c921ce91fa
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3642302
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80490}

Refs: v8/v8@c875e86
PR-URL: #46501
Refs: v8/v8@c875e86
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@sepehrst sepehrst deleted the cherrypick-v8-c875e86df1d7-v18 branch March 17, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sepehrst @nodejs-github-bot @juanarbol @targos @gengjiawen @MylesBorins