Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: enable api-invalid-label.any.js in encoding WPTs #46506

Merged
merged 1 commit into from
Feb 7, 2023
Merged

test: enable api-invalid-label.any.js in encoding WPTs #46506

merged 1 commit into from
Feb 7, 2023

Conversation

panva
Copy link
Member

@panva panva commented Feb 5, 2023 •
edited
Loading

Enables api-invalid-label.any.js WPTs to run.

@panva panva added test Issues and PRs related to the tests. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. labels Feb 5, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49394/

@panva panva force-pushed the more-encoding-wpt branch from 7807548 to 8cd9aaf Compare February 5, 2023 10:37
@panva panva changed the title test: enable single-byte-decoder.window.js in encoding WPTs test: enable api-invalid-label.any.js in encoding WPTs Feb 5, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 5, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva force-pushed the more-encoding-wpt branch from 8cd9aaf to 6d4985e Compare February 5, 2023 16:38
@panva panva added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva force-pushed the more-encoding-wpt branch from 6d4985e to 7b0407d Compare February 5, 2023 20:10
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Feb 6, 2023
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49430/

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 6, 2023
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Open
18 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 7, 2023
@nodejs-github-bot nodejs-github-bot merged commit 4d36ebd into nodejs:main Feb 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 4d36ebd

MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@panva @MylesBorins
test: enable api-invalid-label.any.js in encoding WPTs
641e177 
PR-URL: #46506
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@panva @danielleadams
test: enable api-invalid-label.any.js in encoding WPTs
4fb2fc7 
PR-URL: #46506
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@panva @nodejs-github-bot @jasnell @targos @cjihrig @tniessen