test: fix IPv6 checks on IBM i #46546

abmusse · 2023-02-07T19:10:01Z

This fix should help resolve some test failures:

That fail with:

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ 'Unknown system error -42'
- 'EADDRNOTAVAIL'
    at Socket.<anonymous> (/home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi73-ppc64/test/parallel/test-net-autoselectfamilydefault.js:131:18)
    at Socket.<anonymous> (/home/IOJS/build/workspace/node-test-commit-ibmi/nodes/ibmi73-ppc64/test/common/index.js:448:15)
    at Socket.emit (node:events:518:28)
    at emitErrorNT (node:internal/streams/destroy:151:8)
    at emitErrorCloseNT (node:internal/streams/destroy:116:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 'Unknown system error -42',
  expected: 'EADDRNOTAVAIL',
  operator: 'strictEqual'
}

Node.js v20.0.0-pre

The issues I discovered were 2 fold:

The hasIPv6 function cannot determine IPv6 on IBM i. The loop back interface on IBM i is named *LOOPBACK.
When IPv6 is disabled IBM i returns EUNATCH (errno 42). For now, I've added an errno check in test case for. I believe that libuv needs to get updated to handle EUNATCH so that the error code can be addressed as EUNATCH. Similar to include: add EOVERFLOW status code mapping libuv/libuv#3145

CC @nodejs/platform-ibmi
CC @richardlau

test/parallel/test-net-autoselectfamily.js

github-actions · 2023-02-08T19:27:29Z

Failed to start CI

- Validating Jenkins credentials
✖  Jenkins credentials invalid

https://github.com/nodejs/node/actions/runs/4127678728

richardlau · 2023-02-20T12:34:21Z

@abmusse Can you rebase this to fix the conflict?

abmusse · 2023-02-21T18:08:54Z

@abmusse Can you rebase this to fix the conflict?

@richardlau
Fixed up the conflict by rebasing and squashed all intermediate commits into one commit.

nodejs-github-bot · 2023-02-22T13:31:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49876/

nodejs-github-bot · 2023-02-22T17:54:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49888/

richardlau · 2023-02-22T18:03:20Z

This fix should help resolve some test failures:

test.parallel/test-net-autoselectfamily

test.parallel/test-net-autoselectfamilydefault

FWIW I ran an IBM i CI build for this:
https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/1072
when compared to today's daily IBM i CI:
https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/1070
parallel/test-net-autoselectfamily no longer fails 🎉. However parallel/test-net-autoselectfamilydefault is still failing -- presumably this PR should be modifying that test as well based on the PR description.

abmusse · 2023-02-22T19:16:28Z

This fix should help resolve some test failures:

test.parallel/test-net-autoselectfamily

test.parallel/test-net-autoselectfamilydefault

FWIW I ran an IBM i CI build for this: https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/1072 when compared to today's daily IBM i CI: https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/1070 parallel/test-net-autoselectfamily no longer fails tada. However parallel/test-net-autoselectfamilydefault is still failing -- presumably this PR should be modifying that test as well based on the PR description.

Good catch @richardlau I need to apply the same errno 42 check in that file as well!

        else if (common.isIBMi) {
          // IBMi returns EUNATCH (ERRNO 42) when IPv6 is disabled
          // keep this errno assertion until EUNATCH is recognized by libuv
          assert.strictEqual(error.errno, -42);
        }

Update added fix in

e8a7d20

nodejs-github-bot · 2023-02-22T19:27:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/49892/
IBM i CI showing both tests now pass: https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/1073

nodejs-github-bot · 2023-02-23T14:45:00Z

Landed in c2c61e0

juanarbol · 2023-03-01T20:22:57Z

This is not landing cleanly on v18.x

richardlau · 2023-03-01T20:30:23Z

@juanarbol This hasn't gone out in a current release yet so it's too early to be considered for v18.x.

PR-URL: #46546 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

When IPv6 is disabled IBM i returns EUNATCH (errno 42) instead of EADDRNOTAVAIL. libuv 1.46.0 adds EUNATCH errno We can now use error.code to refer to EUNATCH in node versions that use libuv 1.46.0. PR-URL: #48050 Refs: #48049 Refs: #46546 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

When IPv6 is disabled IBM i returns EUNATCH (errno 42) instead of EADDRNOTAVAIL. libuv 1.46.0 adds EUNATCH errno We can now use error.code to refer to EUNATCH in node versions that use libuv 1.46.0. PR-URL: nodejs#48050 Refs: nodejs#48049 Refs: nodejs#46546 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

PR-URL: #46546 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs/node#46546 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 7, 2023

lpinca approved these changes Feb 7, 2023

View reviewed changes

test/parallel/test-net-autoselectfamily.js Outdated Show resolved Hide resolved

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 8, 2023

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 8, 2023

richardlau approved these changes Feb 8, 2023

View reviewed changes

richardlau added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Feb 8, 2023

cjihrig approved these changes Feb 9, 2023

View reviewed changes

richardlau removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Feb 9, 2023

jasnell approved these changes Feb 11, 2023

View reviewed changes

richardlau added ibm i Issues and PRs related to the IBM i platform. request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 20, 2023

test: fix IPv6 checks on IBM i

6871813

abmusse force-pushed the ibmi-ipv6-test-fix branch from 9b4f649 to 6871813 Compare February 21, 2023 18:07

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023

fixup! test: fix IPv6 checks on IBM i

e8a7d20

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 22, 2023

github-actions bot mentioned this pull request Feb 23, 2023

CI Reliability 2023-02-23 nodejs/reliability#504

Open

31 tasks

richardlau approved these changes Feb 23, 2023

View reviewed changes

richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2023

nodejs-github-bot merged commit c2c61e0 into nodejs:main Feb 23, 2023

abmusse deleted the ibmi-ipv6-test-fix branch February 23, 2023 15:13

github-actions bot mentioned this pull request Feb 24, 2023

CI Reliability 2023-02-24 nodejs/reliability#505

Open

25 tasks

juanarbol added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Mar 1, 2023

targos mentioned this pull request Mar 14, 2023

v19.8.0 release proposal #47087

Merged

abmusse mentioned this pull request May 17, 2023

test: handle EUNATCH #48050

Closed

richardlau mentioned this pull request Nov 16, 2023

request: access to the AIX CI Machine nodejs/build#3571

Closed

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: fix IPv6 checks on IBM i #46546

test: fix IPv6 checks on IBM i #46546

abmusse commented Feb 7, 2023

github-actions bot commented Feb 8, 2023

richardlau commented Feb 20, 2023

abmusse commented Feb 21, 2023

nodejs-github-bot commented Feb 22, 2023

nodejs-github-bot commented Feb 22, 2023

richardlau commented Feb 22, 2023

abmusse commented Feb 22, 2023 •

edited

Loading

nodejs-github-bot commented Feb 22, 2023 •

edited by richardlau

Loading

nodejs-github-bot commented Feb 23, 2023

juanarbol commented Mar 1, 2023

richardlau commented Mar 1, 2023

test: fix IPv6 checks on IBM i #46546

test: fix IPv6 checks on IBM i #46546

Conversation

abmusse commented Feb 7, 2023

github-actions bot commented Feb 8, 2023

richardlau commented Feb 20, 2023

abmusse commented Feb 21, 2023

nodejs-github-bot commented Feb 22, 2023

nodejs-github-bot commented Feb 22, 2023

richardlau commented Feb 22, 2023

abmusse commented Feb 22, 2023 • edited Loading

Update added fix in

nodejs-github-bot commented Feb 22, 2023 • edited by richardlau Loading

nodejs-github-bot commented Feb 23, 2023

juanarbol commented Mar 1, 2023

richardlau commented Mar 1, 2023

abmusse commented Feb 22, 2023 •

edited

Loading

nodejs-github-bot commented Feb 22, 2023 •

edited by richardlau

Loading