Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,crypto: update WebCryptoAPI WPT #46575

Closed
wants to merge 1 commit into from
Closed

test,crypto: update WebCryptoAPI WPT #46575

wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Feb 8, 2023

git node wpt WebCryptoAPI

@panva panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. webcrypto labels Feb 8, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 8, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 12, 2023
@panva panva marked this pull request as draft February 15, 2023 19:11
@panva panva removed request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 15, 2023
@panva
Copy link
Member Author

panva commented Feb 15, 2023

I have two upstream WPT PRs open that I'm hoping will get merged soon(ish). When they're merged I'll make this ready again.

@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 16, 2023
@panva panva marked this pull request as ready for review February 16, 2023 12:54
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 16, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49611/

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 17, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/46575
✔  Done loading data for nodejs/node/pull/46575
----------------------------------- PR info ------------------------------------
Title      test,crypto: update WebCryptoAPI WPT (#46575)
Author     Filip Skokan  (@panva)
Branch     panva:wpt-bump-webcrypto -> nodejs:main
Labels     crypto, test, author ready, needs-ci, webcrypto
Commits    1
 - test,crypto: update WebCryptoAPI WPT
Committers 1
 - Filip Skokan 
PR-URL: https://github.com/nodejs/node/pull/46575
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Luigi Pinca 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46575
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Luigi Pinca 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - test,crypto: update WebCryptoAPI WPT
   ℹ  This PR was created on Wed, 08 Feb 2023 17:14:35 GMT
   ✔  Approvals: 4
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46575#pullrequestreview-1289706439
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46575#pullrequestreview-1289851657
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/46575#pullrequestreview-1289895072
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/46575#pullrequestreview-1290259897
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-02-17T06:11:44Z: https://ci.nodejs.org/job/node-test-pull-request/49611/
- Querying data for job/node-test-pull-request/49611/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4204050590

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Feb 17, 2023
@panva
Copy link
Member Author

panva commented Feb 17, 2023

Landed in eb2a1ab

@panva panva closed this Feb 17, 2023
@panva panva removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Feb 17, 2023
panva added a commit that referenced this pull request Feb 17, 2023
@panva
test,crypto: update WebCryptoAPI WPT
eb2a1ab 
PR-URL: #46575
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
@panva @MylesBorins
test,crypto: update WebCryptoAPI WPT
f4fe58b 
PR-URL: #46575
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
Merged
MylesBorins pushed a commit that referenced this pull request Feb 20, 2023
@panva @MylesBorins
test,crypto: update WebCryptoAPI WPT
0f75633 
PR-URL: #46575
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@panva @danielleadams
test,crypto: update WebCryptoAPI WPT
99bfbed 
PR-URL: #46575
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@panva @nodejs-github-bot @jasnell @lpinca @anonrig @VoltrexKeyva @aduh95