Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-v8-collect-gc-profile-in-worker.js #46735

Merged
merged 1 commit into from
Feb 24, 2023
Merged

test: fix test-v8-collect-gc-profile-in-worker.js #46735

merged 1 commit into from
Feb 24, 2023

Conversation

theanarkh
Copy link
Contributor

fix test-v8-collect-gc-profile-in-worker.js.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 19, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49732/

@github-actions github-actions bot mentioned this pull request Feb 20, 2023
Open
24 tasks
@joyeecheung joyeecheung mentioned this pull request Feb 20, 2023
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49809/

This was referenced Feb 21, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49902/

@github-actions github-actions bot mentioned this pull request Feb 23, 2023
Open
31 tasks
@theanarkh theanarkh added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2023
@theanarkh
Copy link
Contributor Author

Why node-test-commit-aix pending all the time 🤔.

@theanarkh theanarkh force-pushed the fix_test-v8-collect-gc-profile-in-worker.js branch from 528928a to d3d115d Compare February 23, 2023 14:24
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49938/

@github-actions github-actions bot mentioned this pull request Feb 24, 2023
Open
25 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49967/

@theanarkh theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit b3663e0 into nodejs:main Feb 24, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in b3663e0

@github-actions github-actions bot mentioned this pull request Feb 25, 2023
Open
28 tasks
@github-actions github-actions bot mentioned this pull request Feb 26, 2023
Open
15 tasks
targos pushed a commit that referenced this pull request Mar 13, 2023
@theanarkh @targos
test: fix test-v8-collect-gc-profile-in-worker.js
9c7a2e3 
PR-URL: #46735
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@theanarkh @danielleadams
test: fix test-v8-collect-gc-profile-in-worker.js
ea71a2a 
PR-URL: #46735
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@theanarkh @nodejs-github-bot @jasnell @lpinca @cjihrig @tniessen