Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: update CODEOWNERS of url implementations #46775

Merged
merged 1 commit into from
Feb 24, 2023
Merged

meta: update CODEOWNERS of url implementations #46775

merged 1 commit into from
Feb 24, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Feb 22, 2023

This pull request updates the codeowners document and adds @nodejs/url team to URL related files and dependencies

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 22, 2023
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 22, 2023
mcollina
mcollina approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit b6c56cb into nodejs:main Feb 24, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in b6c56cb

targos pushed a commit that referenced this pull request Mar 13, 2023
@anonrig @targos
meta: update CODEOWNERS of url implementations
4e0b932 
PR-URL: #46775
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@anonrig @danielleadams
meta: update CODEOWNERS of url implementations
55f1cfd 
PR-URL: #46775
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
@danielleadams
Copy link
Contributor

I think this is blocked by #46410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@debadree25 debadree25 debadree25 approved these changes

@ronag ronag ronag approved these changes

@lpinca lpinca lpinca approved these changes

@lemire lemire lemire approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@anonrig @nodejs-github-bot @danielleadams @mcollina @lemire @lpinca @ronag @debadree25 @RaisinTen