-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove useless WPT init scripts #46801
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
panva:remove-useless-init-scripts
Feb 25, 2023
Merged
test: remove useless WPT init scripts #46801
nodejs-github-bot
merged 1 commit into
nodejs:main
from
panva:remove-useless-init-scripts
Feb 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Feb 23, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 23, 2023
lpinca
approved these changes
Feb 23, 2023
panva
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Feb 23, 2023
lpinca
added
dont-land-on-v14.x
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
and removed
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backport-blocked-v14.x
labels
Feb 23, 2023
25 tasks
jasnell
approved these changes
Feb 24, 2023
panva
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 24, 2023
targos
approved these changes
Feb 24, 2023
28 tasks
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 25, 2023
Landed in 2e5cb5b |
15 tasks
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46801 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #46801 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46801 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These init scripts are no longer needed, they're setting globals which are already globals in v18.x