Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add trailing commas to more internal files #46811

Merged
merged 1 commit into from
Feb 26, 2023
Merged

lib: add trailing commas to more internal files #46811

merged 1 commit into from
Feb 26, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 24, 2023

We're almost there, I'm two commits away from having the full lib/ covered.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 24, 2023
@debadree25 debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Feb 24, 2023
MoLow
MoLow approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for sake of commit queue being happy

@aduh95 aduh95 merged commit 5f76836 into nodejs:main Feb 26, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 26, 2023

Landed in 5f76836

@aduh95 aduh95 deleted the internal-dangle branch February 26, 2023 10:34
targos pushed a commit that referenced this pull request Mar 13, 2023
@aduh95 @targos
lib: add trailing commas to more internal files
8fb19f7 
PR-URL: #46811
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@aduh95 @targos
lib: add trailing commas to more internal files
f914bff 
PR-URL: #46811
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@aduh95 @danielleadams
lib: add trailing commas to more internal files
31578ab 
PR-URL: #46811
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debadree25 debadree25 debadree25 approved these changes

@trivikr trivikr trivikr approved these changes

@MoLow MoLow MoLow approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @jasnell @MoLow @trivikr @debadree25