test_runner: avoid running twice tests in describe #46888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dont-land-on-v14.x
needs-ci
MoLow
force-pushed
the
fix-test-in-describe
branch
from
d9021c1
to
e3c44e3
Compare
MoLow
changed the title
ljharb
reviewed
Feb 28, 2023
1 task
aduh95
reviewed
Feb 28, 2023
There was a problem hiding this comment.
I'm not too sure if returning undefined is the correct move (rather than a PromiseResolve()), is there some use case when it would be useful for the users to make the difference?
Other than that, I think I would word the commit as avoid running tests twice, but I'm not an English native speaker, so if the current order is correct, I'm fine with it :)
returning a |
|
That sounds less confusing an API to me than one that only sometimes returns a Promise - the latter is literally what's referred to as "zalgo". |
benjamingr
approved these changes
Mar 1, 2023
jasnell
reviewed
Mar 2, 2023
MoLow
force-pushed
the
fix-test-in-describe
branch
from
2c235f2
to
95d8d57
Compare
|
@nodejs/test_runner since this is a bug in main I'd like to land it, additional reviews/approvals will be appreciated |
ljharb
approved these changes
Mar 2, 2023
| } | ||
|
|
||
| function runInParentContext(Factory) { | ||
| function runInParentContext(Factory, addShorthands = true) { | ||
| function run(name, options, fn, overrides) { |
There was a problem hiding this comment.
Suggested change
| function run(name, options, fn, overrides) { | |
| async function run(name, options, fn, overrides) { |
doing this instead would ensure it always returns a promise
There was a problem hiding this comment.
@ljharb change has caused invalid arguments to reject instead of throw so I will revert this
github-actions
bot
removed
the
request-ci
aduh95
approved these changes
Mar 2, 2023
MoLow
force-pushed
the
fix-test-in-describe
branch
from
fec80e6
to
95d8d57
Compare
aduh95
approved these changes
Mar 2, 2023
MoLow
added
author ready
github-actions
bot
removed
the
request-ci
MoLow
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/46888 ✔ Done loading data for nodejs/node/pull/46888 ----------------------------------- PR info ------------------------------------ Title test_runner: avoid running twice tests in describe (#46888) Author Moshe Atlow (@MoLow) Branch MoLow:fix-test-in-describe -> nodejs:main Labels author ready, needs-ci, dont-land-on-v14.x, test_runner Commits 1 - test_runner: avoid running twice tests in describe Committers 1 - Moshe Atlow PR-URL: https://github.com/nodejs/node/pull/46888 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46888 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 28 Feb 2023 20:30:39 GMT ✔ Approvals: 2 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/46888#pullrequestreview-1320288015 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46888#pullrequestreview-1322529537 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2023-03-02T22:06:27Z: https://ci.nodejs.org/job/node-test-pull-request/50173/ - Querying data for job/node-test-pull-request/50173/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4320318363 |
MoLow
added a commit
that referenced
this pull request
Mar 3, 2023
PR-URL: #46888 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Landed in a37b72d |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46888 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #46888 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46888 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46887
not the fix itself can be understood in the first commit, the second one just unifies the code,
wanted to make review easier so split into two commits