esm: add a runtime warning when using import assertions #46901
Merged
+50
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
esm
ljharb
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
I think we should wait for a response from tc39/proposal-import-attributes#127 (comment) before landing this.
Comment on lines
+64
to
+65
| 'Import assertions are not a stable feature of the JavaScript language, ' + | ||
| 'avoid relying on their current behavior and syntax as those might change ' + |
There was a problem hiding this comment.
Comma splice.
Suggested change
| 'Import assertions are not a stable feature of the JavaScript language, ' + | |
| 'avoid relying on their current behavior and syntax as those might change ' + | |
| 'Import assertions are not a stable feature of the JavaScript language. ' + | |
| 'Avoid relying on their current behavior and syntax as those might change ' + |
|
It wouldn't be possible for TC39 to provide any timing guarantees - the proposal champions may be able to promise they're ready to present in March, but nobody can predict consensus ahead of time. Multiple delegates have expressed that "assert" syntax is inappropriate for something that's not an assertion anymore, and the web can't use the assertion semantics, so the semantics will change - which suggests to me that the syntax is likely to as well, regardless of whether Chrome decides to unship the current syntax or not. |
jasnell
approved these changes
Mar 2, 2023
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
richardlau
added
dont-land-on-v14.x
lts-watch-v18.x
VoltrexKeyva
approved these changes
Mar 2, 2023
JakobJingleheimer
approved these changes
Mar 2, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5a7491b |
|
@aduh95 This landed without #46901 (comment) being addressed? The current text is incorrect grammar. |
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Mar 6, 2023
nodejs-github-bot
pushed a commit
that referenced
this pull request
Mar 7, 2023
Refs: #46901 (comment) PR-URL: #46971 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
Refs: #46901 (comment) PR-URL: #46971 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
Refs: #46901 (comment) PR-URL: #46971 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
Refs: #46901 (comment) PR-URL: #46971 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 task
targos
added
backported-to-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #46830
/cc @nodejs/loaders