-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inspector: fix session.disconnect crash #46942
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
theanarkh:fix_session_disconnect_crash
Mar 14, 2023
Merged
inspector: fix session.disconnect crash #46942
nodejs-github-bot
merged 1 commit into
nodejs:main
from
theanarkh:fix_session_disconnect_crash
Mar 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
inspector
Issues and PRs related to the V8 inspector protocol
needs-ci
PRs that need a full CI run.
labels
Mar 3, 2023
theanarkh
force-pushed
the
fix_session_disconnect_crash
branch
from
March 3, 2023 20:07
c38daf7
to
626e3ce
Compare
juanarbol
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Mar 4, 2023
theanarkh
force-pushed
the
fix_session_disconnect_crash
branch
from
March 4, 2023 02:01
626e3ce
to
ee09149
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Mar 4, 2023
17 tasks
theanarkh
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Mar 5, 2023
This was referenced Mar 6, 2023
@addaleax Hi, can you help review this PR ? thanks ! |
addaleax
reviewed
Mar 14, 2023
theanarkh
force-pushed
the
fix_session_disconnect_crash
branch
from
March 14, 2023 16:28
ee09149
to
20c3a37
Compare
theanarkh
force-pushed
the
fix_session_disconnect_crash
branch
from
March 14, 2023 16:32
20c3a37
to
eefabde
Compare
addaleax
approved these changes
Mar 14, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Mar 14, 2023
theanarkh
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 14, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 14, 2023
Landed in f543c05 |
targos
pushed a commit
that referenced
this pull request
Mar 18, 2023
PR-URL: #46942 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Apr 3, 2023
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #46942 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
inspector
Issues and PRs related to the V8 inspector protocol
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix
session.disconnect
crash.When worker calls
session.disconnect()
,JSBindingsSessionDelegate
will be destroyed asynchronously, so we need to make sure thatJSBindingsConnection
is destroyed afterJSBindingsSessionDelegate
.The test is as follows.
The error message is as follows.
make -j4 test
(UNIX), orvcbuild test
(Windows) passes