-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url: allow extension of user provided URL objects #46989
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
whatwg-url
Issues and PRs related to the WHATWG URL implementation.
labels
Mar 7, 2023
anonrig
reviewed
Mar 7, 2023
anonrig
reviewed
Mar 7, 2023
trentm
reviewed
Mar 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (caveat: I'm not a nodejs reviewer)
anonrig
approved these changes
Mar 18, 2023
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Mar 18, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Mar 18, 2023
19 tasks
anonrig
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 19, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 19, 2023
Landed in ad2c3c0 |
This was referenced Mar 20, 2023
Merged
19 tasks
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Jun 24, 2023
PR-URL: nodejs#46989 Fixes: nodejs#46981 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Jun 24, 2023
PR-URL: nodejs#46989 Fixes: nodejs#46981 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Jun 26, 2023
PR-URL: nodejs#46989 Fixes: nodejs#46981 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#46989 Fixes: nodejs#46981 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Jul 9, 2023
PR-URL: nodejs#46989 Fixes: nodejs#46981 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Jul 9, 2023
PR-URL: nodejs#46989 Fixes: nodejs#46981 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams
added
the
backported-to-v18.x
PRs backported to the v18.x-staging branch.
label
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backported-to-v18.x
PRs backported to the v18.x-staging branch.
needs-ci
PRs that need a full CI run.
whatwg-url
Issues and PRs related to the WHATWG URL implementation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #46981